[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v2] xen: allow XSM_FLASK_POLICY only if checkpolicy binary is available
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Fri, 16 Jul 2021 14:00:37 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ROFaK+/NT3lPoinXoNrQPpO3JwD1OpCd4uSjriz1gHA=; b=QgXOwrwuk36M1uMkfEQz2VjTTJ8DsbGBkn3j6OdeIms4LDeB16RQkdZO7K2dnceC62R6V9VruqSoPksacpRFYZoCuKhSGr+gyNeVi+D0VdrF8hf5ySwrGc+9sw8Oo+8UhpPWyTxpT3touFvwWl3X/Hc6TOKxL8HlYqJBI5PuUP1zIU5qzqs2X9e6VmRR4cWB5yIdVXU73WkS2lNih2C5j3JQNT8nDdrxBgnwdDqyQDWyVw8cfmv5YHCN5vTUDemNeo0QV5RruYHbcs9Y0GFxU1iaCI2+YBA6nXXv2T7LFGs6ECX4Ra2PXAPXqK4QQ4BYC5Y9kBGv/jcVeCW6+s/qlA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HlJHUnfG+QPx0TEktSIA2EkkEOt0Tz6AenFtXT8e2MzGs3p498siw2WvdKtzXis0Ud0X9lF896KCjUqY/gRpp1rizjKQFZo2KufT3VhQFMynf57Q6DvUuhLHhpt/7e/N4vU6TFthuE0u/jlhk94antOkLhT4CVmrxkdj/1tCbUQlKcOGDeezyVc2I0OA0EPVUN69900v/I+l4S96zJ9N9UKDymG2Gb01KwngXHi5sUWo7qxEyO3cJ8TXZ/r5XUk/q9scU+p0pPTEut0xOsBgzikxj0ECKy/SXHLouiGBvX5ho//bHVSJLx8oTok+eG4xFhNC59mD6GyadUfHAXeQSg==
- Authentication-results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Fri, 16 Jul 2021 13:00:59 +0000
- Ironport-hdrordr: A9a23:NB2CY6HXbTv1/VbepLqFZpHXdLJyesId70hD6qkvc3Nom52j+/ xGws536faVslcssHFJo6HkBEDyewKiyXcT2/hsAV7CZniahILMFu9fBOTZskXd8kHFh4lgPO JbAtJD4b7LfChHZKTBkXCF+r8bqbHtmsDY5pat854ud3APV0gJ1XYJNu/xKDwReOApP+taKH PR3Ls9m9L2Ek5nEPhTS0N1ENTrlpnurtbLcBQGDxko5E2nii6p0qfzF1y90g0FWz1C7L8++S yd+jaJp5mLgrWe8FvxxmXT55NZlJ/IzcZCPtWFjowwJi/3ggilSYx9U/mpvSwzosuo9FE2+e O87SsIDoBW0Tf8b2u1qRzi103J1ysv0WbrzRuijX7qsaXCNXgHIvsEobgcXgrS6kImst05+r lMxXilu51eCg6FtDjh5vDTPisa1HackD4Hq6o+nnZfWYwRZPt6tooE5n5YF58GAWbT9J0nKu 9zF8vRjcwmMm9yV0qp+lWH/ebcGUjaRny9Mw4/U42uonhrdUlCvg4lLJd1pAZYyHpVIKM0lN gtMcxT5fpzp4EtHPpA7Epoe7rANoX3e2O5DIulGyWuKEg2AQO5l3fJ2sRD2AiLQu1E8HJgou WMbLtn3VRCMn4GT/f+h6F2zg==
- Ironport-sdr: lIRwpBe0jU1A4FvOprSSbQKekzoDmCAP8K3z7j5d2rW/npb1dMr4xPb06+ypTgaNiyDweyAzYC Qq8FhUTkAo1lkP6LXp1ea9XnsekqjM4gdrEp+f2pDnOOTaqzxYVH58dbwQEZcS5wOv3nuTliIJ GxEWjFoZJdFp1TlFDhoTbkNyZZpDGy6yG8FPcN1vM+1gARNhVoA7NPJPM0lHcSE3Vp69nFZ8MK I2dwGENq4zIZflAlgC+DRK2zcyrhj/slGJFjAABDx+DumOTmdmijoS5qgqj3ULLsmUzOe5B+Ux Xqc=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 16/07/2021 13:38, Anthony PERARD wrote:
> This will help prevent the CI loop from having build failures when
> `checkpolicy` isn't available, when doing "randconfig" jobs.
>
> Also, move the check out of Config.mk and into xen/ build system.
> Nothing in tools/ is using that information as it's done by
> ./configure.
>
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> ---
> We might want to have a new Makefile for this kind of check that
> Kconfig is going to use, just to keep the main Makefile a bit cleaner.
> But maybe another time, if more are comming.
I won't nack this patch, but I'm a very firm -2 against it.
v1 is the correct way to go.
~Andrew
|
