[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 08/10] xsm: remove xsm_default_t from hook definitions
- To: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 16 Jul 2021 09:37:58 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c4Lra1NQSNlxKXfen2jIx+E+ykyuj4A1BD+bmvFbKd0=; b=QuTi6MFCAfLXHAagseqTaxKnL3EWcshiKF+SfF7o7grfATO20+o2WnmI3GTbfOfE+oGIgaiCbW0LSmCPIES3z76LWRQDOw1v9C6Xda9DE/5JeoFJKvyTMhmFJQKISmDgocSdb2H1uecaNnPqreOLrU9WycWYi0Amn9/SAdLYGytO2EORlLuBI4C5LNYODUFTdzgtmVbRKT0iPGw2v4pAKoXWyW0NinxMABqblGJfakaonUOAJn3NwqRZKluO9UIoUwbgeCqcfWI8SgF8Ew0l8l/5Ya38f0UUFAawvNaOdJAllo+JxJUi8B48rkc3A+zrbz1Ugcrxv4dqe+vEZfMtgQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XaYnx0pI5gv1R7YMcDWTX8Wfg1UR5qt0ImVW1j5SBwz0pUoZl3D6kifz+lu/wPrB2EIJD5Tt5J49bRqoXTCnej/ZWpaXgGt4TlP77Juer8ysjs/xGCn6N5fe7Rou57Qm+ZK91PPt+FFiTmPI2i/pxm2DcgsM7DsBmr+f7hwoAY0VXg4LyvFfZ5h/70j0yFCLu3ADgekB9k28d4WUuBV84emHF8SpB/wiFdtVUeFBvj7hyGRcDcpe3m27exZExqw1CmjVnaH/8EEV+YjGy8QxqUYuYh4k0WTgZC4rRL4UUzPY6L4gg17vjYmgcb6G70frCwARpRykPkKjl6MHyWD8cw==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Tamas K Lengyel <tamas@xxxxxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Dario Faggioli <dfaggioli@xxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Tim Deegan <tim@xxxxxxx>, Alexandru Isaila <aisaila@xxxxxxxxxxxxxxx>, Petre Pircalabu <ppircalabu@xxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Fri, 16 Jul 2021 07:38:09 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 12.07.2021 22:32, Daniel P. Smith wrote:
> --- a/xen/include/xsm/xsm.h
> +++ b/xen/include/xsm/xsm.h
> @@ -30,53 +30,53 @@ static inline void xsm_security_domaininfo (struct domain
> *d,
> alternative_vcall(xsm_ops.security_domaininfo, d, info);
> }
>
> -static inline int xsm_domain_create (xsm_default_t def, struct domain *d,
> u32 ssidref)
> +static inline int xsm_domain_create (struct domain *d, u32 ssidref)
When you have to touch such lines anyway, may I suggest that you also
take the opportunity and drop the stray blanks immediately ahead of
the opening parenthesis, to bring this file better in line with
./CODING_STYLE? And as just said for a later patch, converting u<N>
to uint<N>_t at this occasion would also be nice, for the same reason.
Jan
|
