[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 07/10] xsm: drop generic event channel labeling
- To: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 16 Jul 2021 09:03:36 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+eenM6kYJAF/iOgZT54XXqCydbCYs4xSnzxr0nwGPqM=; b=cjDaYEAz8QE+SHPj6DQK+508Zx6o97D+VORiWtC14pX/4fPWN06ALDbo0SkHmFXLC7a7d4SS2SEZ2X8mZdwZN/PegGtA31YmIckxHlWv6vomQHVpC+/SddTqarOevMRRSw0ut6yei7A8wcLoMFX2BC+802GJ6jSe25EBw9yNZ2dBAVk4u+qtlLURoH6OrZbuWTks6KC+cWdsmV9ILkMB6pTR/obVdFbaVtdICkHFeKPbMc1a62YWQu4JlBY1k5hhXnV3ZpUaQJDTFooUsqEsoHohN66JgP5CXSm/VS7umxY1VdMeytxP9h2mjlUZvcmk1p72QdVIw5Q6w5wGRZBmOQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XBn9ulV6IAvtdOvG76EiHZpfvF9sz/BxQwXy9EuPxOyoWnA337FP0X+xnPJe7a48VNZ1NKGLKLv5SmeJU6h85Hv0l1GSiYtPtWaTvFrkcaR1GnH4IlfYFMMrLq7gBDKiLx57qfw4xNZa5SKvX/DK9jaZ+DKVch+m+Ff6Q9BF9W+TIS7iziBsonv93pQHHC2ubObXpXZa2dXOxN4cPMSK3ypdPiO1byutEpo4qY3MnmOAWYFQ1gGeZwiFQIgA+pUqxqUqaPfZsElyphSR20tkltNnmz4HaDFI4QbSVOVF2X1QagQyN4OJk+4BkJgCdIK25lCx7zXfprg8km5qP5JkXQ==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Fri, 16 Jul 2021 07:03:52 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 12.07.2021 22:32, Daniel P. Smith wrote:
> The generic event channel labeling has not been used by any XSM module since
> its introduction. This commit removes the capability leaving FLASK labeling
> field always present. In the future if a new XSM module needs to have its own
> channel label, this or a new form can be introduced.
I'm not fully convinced of this removal: Does it get in the way of
anything?
> --- a/xen/include/xen/sched.h
> +++ b/xen/include/xen/sched.h
> @@ -120,15 +120,7 @@ struct evtchn
> unsigned short notify_vcpu_id; /* VCPU for local delivery notification */
> uint32_t fifo_lastq; /* Data for identifying last queue. */
>
> -#ifdef CONFIG_XSM_EVTCHN_LABELING
> union {
> -#ifdef XSM_NEED_GENERIC_EVTCHN_SSID
> - /*
> - * If an XSM module needs more space for its event channel context,
> - * this pointer stores the necessary data for the security server.
> - */
> - void *generic;
> -#endif
> #ifdef CONFIG_XSM_FLASK
> /*
> * Inlining the contents of the structure for FLASK avoids unneeded
This comment's "with only FLASK" now becomes stale, and hence would
imo better be updated.
Jan
|
