[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/4] x86/debug: move domain_pause_for_debugger to debugger.c
- To: Bobby Eshleman <bobby.eshleman@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 14 Jul 2021 11:55:05 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fedO57SkFDDXrNnP/dbrn9xGLKzSS01cyqPY+97YwKg=; b=JYaa5J/UpV08kZ9yMsAYUkNGrZXeHmq4O1/ncVpiqaKRy2TJEyid38Y/y3QrdrbjoBteDDCrX01Icd7K/u4PDwYtnDuUu+AFk2jYcvzOoWJp2AJLF7dzyIKwDva0hyzfZsbTw2fZbXcKtrSOE+nLn7qTC2Bw1SRuG/XAw9XCg6/ff42Y7iD3JLFZCqAWVy6WqVDcBFKVYIgIhr+oQPLaagtcrvULb7KLwN+hitqbqwYHZvYS3AgsqhPgtww82b5mtZ2mfW30pNnJSJQxRUqJdz3Xo7k+BGOT1FZFyER+tmlqQkdPz50FbxrVH3XgeypDiSHpeUH75OdgIJpFlpMo9g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CoUYdxNVnW2+saz9Qy0vxWeaHna8UQrO/YdTnxM001lxuri07/gO710Fywg7bRDrpRcRkhOTiivtIm/a1ELRMbqSDPEtXtoK8jbpjfzfe0UM5n1Jk7RiIRXLTfQgqyFgr30ceyACpZjLthWE2XYKxGRx/ErXR+QWiROHc+l9/+Yg4XNyAZGrNqh6bWO+P0Eddb59jB5JMwyzF5+xowGYPU1V4+AJ3+0rv9bEc816awhIibzTwnKZLdh5T6XIrrRt4c4MOGR1yAXZ9I3Mp64jQis5kIxiKwKwRAoGbjwrgVJfoCS6kcgQDQIwn8lOfkDjwvV8NrDjkT0rWb/65T0mGA==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Elena Ufimtseva <elena.ufimtseva@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 14 Jul 2021 09:55:14 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 13.07.2021 03:59, Bobby Eshleman wrote:
> The function domain_pause_for_debugger() is conditionally compiled if
> CONFIG_CRASH_DEBUG=y. Instead of placing an extra #ifdef inside
> domain.c, this commit moves domain_pause_for_debugger() into
> x86/debugger.c which is only built by Kbuild given CONFIG_CRASH_DEBUG=y.
>
> Signed-off-by: Bobby Eshleman <bobby.eshleman@xxxxxxxxx>
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
preferably with ...
> --- a/xen/arch/x86/debugger.c
> +++ b/xen/arch/x86/debugger.c
> @@ -15,6 +15,18 @@
> #include <xen/event.h>
> #include <xen/sched.h>
>
> +void domain_pause_for_debugger(void)
> +{
> + struct vcpu *curr = current;
... "const" added here while you're moving this anyway.
Jan
|
