Re: [PATCH v20210701 07/40] tools: create libxensaverestore

[Julien Grall <julien@xxxxxxx>]

Hi Olaf,

On 01/07/2021 10:56, Olaf Hering wrote:
> Move all save/restore related code from libxenguest.so into a separate
> library libxensaverestore.so. The only consumer is libxl-save-helper.
> There is no need to have the moved code mapped all the time in binaries
> where libxenguest.so is used.
>
> According to size(1) the change is:
>     text           data     bss     dec     hex filename
>   187183           4304      48  191535   2ec2f guest/libxenguest.so.4.15.0
>
>   124106           3376      48  127530   1f22a guest/libxenguest.so.4.15.0
>    67841           1872       8   69721   11059 
> saverestore/libxensaverestore.so.4.15.0
>
> While touching the files anyway, take the opportunity to drop the
> redundant xg_sr_ filename prefix.
>
> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
> Acked-by: Wei Liu <wl@xxxxxxx>
The changelog is not very useful to keep in the commit message. We 
usally add --- on its own line before so they will get stripped when the 
patch is applied.
This comment applies for the full series. But I can deal with this patch 
if I happen to commit it.
Cheers,

--
Julien Grall