Re: [PATCH v4 4/5] tools/libs/gnttab: Fix PAGE_SIZE redefinition error

[Julien Grall <julien@xxxxxxx>]

Hi Costin,

On 08/06/2021 13:35, Costin Lupu wrote:
> If PAGE_SIZE is already defined in the system (e.g. in /usr/include/limits.h
> header) then gcc will trigger a redefinition error because of -Werror. This
> patch replaces usage of PAGE_* macros with XC_PAGE_* macros in order to avoid
> confusion between control domain page granularity (PAGE_* definitions) and
> guest domain page granularity.
>
> The exception is in osdep_xenforeignmemory_map() where we need the system page
Did you mean osdep_gnttab_grant_map?

> size to check whether the PFN array should be allocated with mmap() or with
> dynamic allocation.
>
> Signed-off-by: Costin Lupu <costin.lupu@xxxxxxxxx>
Other than the question above:

Reviewed-by: Julien Grall <jgrall@xxxxxxxxxx>

Cheers,

--
Julien Grall