[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tools/libxc: use uint32_t for pirq in xc_domain_irq_permission
- To: Igor Druzhinin <igor.druzhinin@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Thu, 8 Jul 2021 02:11:09 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=i8FAv9IDgQu+DVEWgwyu0whT6GuC795fF+5/SB+oysQ=; b=UKIdqzdS0ieNuPtMfJ0Y3Phi+sOP2zxcFDvRJzEca4Z2tLGSOZoZTxBHn5m6+EWZO728t8yUrVdclRMuuEoAQNCdX7q6K+gyrk47JAU2gklsmmiV9m9f2Y9cb2Cb2THvW/Ax7QUQFox8gVfk2CVy9Uo7bTqitzdnLPl6WjINn1xfv6voKrdsVCnSt6PFNmGSMmbYiVqiomB7bJjjnCTW0OlstrtN2TUxh3/CQZRUTb5yCPx4BDzTKx9m8T4fBw0eUC+NIuiJ3J+/GoYALBwkXOONkX2eqbNMWkM6rD09abIOHNGXD6hyq+uVG+Ke6riCytRs3OC/Z0dMRIPF18fqSg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JpAYrn0SpZ3QwZ1EM85IOviz4Wo4ZM+Sne/N3gGlzUvmjAgAabNJ3w3FtZrfTgBp2s/ZMdWlgPwhKjLPJfUJnh1+alx0SNt4DYG2ahox9x9hAiWDAB8c4l1a8T3IzXOXq1i8gPY8IaZL7oUJg+JDWSo3xccXxWKrkTmBEkqB/4MxklT54NatEXP1FZ4BaZXMX+xq5518+grG7IuqWbGn4jKaa1o38A//XA0KBGrWNINp3JdBaYX12/aHYaSYe7L/CmHoPR6rguPYrU0CLYZqi15yeb8m49VYA6MSKTq2nTIiwTaafPKLwFqrvVpCA2s4tmCeOMvmjJlZvp1CwBjXUQ==
- Authentication-results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: <iwj@xxxxxxxxxxxxxx>, <wl@xxxxxxx>, <george.dunlap@xxxxxxxxxx>, <julien@xxxxxxx>, <sstabellini@xxxxxxxxxx>, <jgross@xxxxxxxx>, <christian.lindig@xxxxxxxxxx>, <dave@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 08 Jul 2021 01:11:30 +0000
- Ironport-hdrordr: A9a23:kaWxvaPeGAxLxcBcTy/155DYdb4zR+YMi2TDiHoedfUFSKOlfp 6V8MjztSWVtN4QMEtQ/uxoS5PwP080kqQFnrX5XI3SIDUO3VHIEGgM1/qY/9SNIVyGygcZ79 YcT0EcMqyCMbEZt7eD3ODQKb9Jq7PrgcPY55aq854ud3ANV0gJ1XYINu/xKDwSeOApP+tcKH PR3Ls8m9L2Ek5nH/hTS0N1ENTrlpnurtbLcBQGDxko5E2nii6p0qfzF1y90g0FWz1C7L8++S yd+jaJp5mLgrWe8FvxxmXT55NZlJ/IzcZCPtWFjowwJi/3ggilSYx9U/mpvSwzosuo9FE2+e O87SsIDoBW0Tf8b2u1qRzi103LyzA18ULvzleenD/KvdH5bChSMbsCuatpNj/ir2YwttB116 xGm0iDsYBMMB/GlCPho/DVShBRkFauq3ZKq59Rs5Vma/pbVFZtl/1ZwKsMe61wWh4SqbpXUN WGNfusocq/KjihHinkVgAF+q3fYpwxdi32CHTq9PbliwS/MRhCvgIlLfck7wA9HaQGOtJ5Dt T/Q9BVfY51P7krhIJGdao8qJiMeyDwqSylChPbHb2gLtBdB07w
- Ironport-sdr: HiOKPLIT17ZNjUUowMGWiZC/eXCB0SZ3feXCOptZZOq6uJ0blGUA13Nq64bZ0lvSUHnf9innor K0UJdSzFv4T3gZEAgFpup9sFejTU/v8l/slnXMVgdAvIyQJd6bFh29GCKvVZ7VOofCNcPI4VtU KEWS8QZb9nsUgFw+GUTWwouxSz1tt4oPKykHMqkc6pApiXyHaFgZ8TFoN1bqQUIg23huYrD0hB UyPPnTn+bEnZk6zbo/irtQIsk/zypJWO2Sun/0lW044vp2PRAYZTY7cHJD0oN46p0mxy8bjYCe O70=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 08/07/2021 02:08, Igor Druzhinin wrote:
> On 07/07/2021 10:19, Andrew Cooper wrote:
>> On 07/07/2021 08:46, Jan Beulich wrote:
>>>> --- a/tools/include/xenctrl.h
>>>> +++ b/tools/include/xenctrl.h
>>>> @@ -1385,7 +1385,7 @@ int xc_domain_ioport_permission(xc_interface
>>>> *xch,
>>>> int xc_domain_irq_permission(xc_interface *xch,
>>>> uint32_t domid,
>>>> - uint8_t pirq,
>>>> + uint32_t pirq,
>>>> uint8_t allow_access);
>>> Take the opportunity and also change "allow_access" to bool? Or is
>>> use of bool prohibited in external interfaces?
>>
>> We've got bool's in the interface already.
>
> Where exactly? I couldn't find a single "bool".
$ git grep -w bool -- :/tools/include/xen*.h
../tools/include/xenctrl.h:1844: uint32_t
domid, bool restore,
../tools/include/xenctrl.h:1846: unsigned int
nr_features, bool pae, bool itsc,
../tools/include/xenctrl.h:1847: bool
nested_virt, const struct xc_xend_cpuid *xend);
../tools/include/xenctrl.h:1954:int
xc_altp2m_get_domain_state(xc_interface *handle, uint32_t dom, bool *state);
../tools/include/xenctrl.h:1955:int
xc_altp2m_set_domain_state(xc_interface *handle, uint32_t dom, bool state);
and loads more.
~Andrew
|
