[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tools: Fix CPSR/SPSR print size
- To: Julien Grall <julien@xxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Tue, 6 Jul 2021 15:30:27 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZxALtI/CSDAvLxAy9fB4gi3w/R6VJ/8FTUddzojXXE0=; b=KXQCVfpsS3BnNEu+tQoVhHXx5S0DGTCK2/FBtNoFGYlqCOZJsT0eqT/OByQ5Z3Jgb7BJ29y7IK9FVtbeI4xLmutlVF12vDRaouHPmYGRser4Is1oTjda4wqLQMerI/VbMsh41WBuSe0/60vyS1wux6kqHR12enBgmNQk1MDUfia2Nr3zc2UoM+lnrX/5hq20DtbJGh9qpYadl5SY0xGHuKySLjs2DJxjmpJHabv98AU6m20hs9jAY/Q2I/b72EkuKu3aeeSJ4vR5RDe6v1BK5jZwj64Jqk2U12pktjnV0PMnRnjygglg5UdXGgc5c75mFKORJnWaitMO0CNaxQT9mg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Jeho25QUng4YzcFXFrMu1wJSxyBlHEfWKlMiV70H4BDrfDxvqlZIRyHEXYtOV3CuC+paLhv4vcx5ssH59/QNaPYD2tIppSDURQfDmpxxxFTng+SxbVU39BGhzpo4osj4F6NJqKPxYLcfnlYW7ykXWafNCvt0HEiCPTVRgFqbsgij4qaRsPP2hrJv2s/7x0E6XCv3OJcySDf6hcZGLEgUNjLCBkdm6UXgnoDP2RV/7gmk9SsStYv1LSt8HZ3gGVRHMc0JtDBR3jGFBkF48xes2HgevCmgvW0LT+3/sqsHzraSeeapujHR1XGRCegN3QwuATLwF7csNXoabyfWm6uG3g==
- Authentication-results-original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "jgrall@xxxxxxxxxx" <jgrall@xxxxxxxxxx>, Michal Orzel <Michal.Orzel@xxxxxxx>, "olaf@xxxxxxxxx" <olaf@xxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>
- Delivery-date: Tue, 06 Jul 2021 15:31:02 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
- Thread-index: AQHXcnkI0yrA0BW0E067MCMRzZDicKs2DqIAgAACDoCAAADKgIAAAUEA
- Thread-topic: [PATCH] tools: Fix CPSR/SPSR print size
> On 6 Jul 2021, at 16:25, Julien Grall <julien@xxxxxxx> wrote:
>
>
>
> On 06/07/2021 16:23, Bertrand Marquis wrote:
>> Hi Julien,
>
> Hi Bertrand,
>
>>> On 6 Jul 2021, at 16:15, Julien Grall <julien@xxxxxxx> wrote:
>>>
>>> Hi Bertrand,
>>>
>>> Thanks for the fix. I forgot to check the full tools build when sending the
>>> first fix :(.
>>>
>>> On 06/07/2021 16:09, Bertrand Marquis wrote:
>>>> With the changes of register size introduced in
>>>> 918b8842a852e0e7446286f546724b1c63c56c66, CPSR and SPSR are now stored
>>>> as 64bit values.
>>>> Fix the print size to use 64bit type.
>>>
>>> Can you add a fixes tag? This makes easier to find bug fix in the tree.
>>>
>>> For this patch it would be:
>>>
>>> Fixes: 918b8842a852 ("arm64: Change type of hsr, cpsr, spsr_el1 to
>>> uint64_t")
>> Sure. Patch incoming in the next minutes.
>
> I can fix it on commit.
Up to you, I also just sent a v2 if it is easier :-)
Cheers
Bertrand
>
>>>
>>>> Signed-off-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
>>>
>>> Just to confirm, with this patch and mine the tools build successfully on
>>> 32-bit and 64-bit?
>> Yes I have a full build running with both patches added for arm32, arm64 and
>> x86_64.
>
> Perfect!
>
> Acked-by: Julien Grall <jgrall@xxxxxxxxxx>
>
> Cheers,
>
> --
> Julien Grall
|
