[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4] arm64: Change type of hsr, cpsr, spsr_el1 to uint64_t


  • To: Olaf Hering <olaf@xxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Tue, 6 Jul 2021 13:11:17 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lwTRiBSMJWJECrC2T4SZGbL6SloV1G9IFCn5dmMubgc=; b=c5sSzS75AcoaW69BqGYqLzdqNuVZF7I+/Dju/tfB3kBQ0QzEUBWCgWOXxTEmf+w7mvWo6A7Y6/i8xf4Ux47XCkLfrgeZnRflDWWuhQTycFy0FrDePvtDwGaJJIWIZ9cqG9yNZARY1kPMuUVqOEh8QQLi42L6bgSjtYmqc3MZEdnUqK8Zbl5tqUFOmuEut45WZjXzlsK4R+XSuxcAz5/2J2TEj4mEGrEBs70Gb6+uuWC0qBs27e+ID2iKrrOKA4KAokU3nKC7y/96hOHhJGZklVl0afZbNWy3tqmeNsb8pvNXdi/KS/WhrvHmejItsEwTNeI78mj91yaFUjjVKzZAxg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dlsCNWd6oP6qOeHk2khyvZmg0dJ+0HWF2N2nRqdBgJ2pvNaHbTV4pr8BxJFvNc02AdbHRQ7xZL2jjECNPg9hQeAqknBUejvbI9W+Tcl2ll6MPj8cQWaSVycfB/P56+rCPn+ziSwarHk7Y+ZrzvhkTrrAPJzz465lQPbxso/z7f5KSOX/+HgyR0GrcHdl/g+4+CFqPtSZ/tk7B8zKoDEg0irJN9Lae3HZ+RTeCYIFAD4YpfjYLAxqTkCS8s0gpBj5oyY/nF9V44YDgwJ0NYKK2WZpB4cBlbqxv84xer2P/epPrmI9dih0fThzTIeGV0xZI04Wx691kNaMB4Tj/tHY3w==
  • Authentication-results: esa4.hc3370-68.iphmx.com; dkim=hardfail (body hash did not verify [final]) header.i=@citrix.onmicrosoft.com
  • Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, "Ian Jackson" <iwj@xxxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Wei Liu <wl@xxxxxxx>, Tamas K Lengyel <tamas@xxxxxxxxxxxxx>, Alexandru Isaila <aisaila@xxxxxxxxxxxxxxx>, Petre Pircalabu <ppircalabu@xxxxxxxxxxxxxxx>, <bertrand.marquis@xxxxxxx>
  • Delivery-date: Tue, 06 Jul 2021 12:11:38 +0000
  • Ironport-hdrordr: A9a23:I5j/KK9Z9jKImP+Tzl1uk+E2db1zdoMgy1knxilNoENuHPBwxv rAoB1E73PJYVYqOE3Jmbi7Sc69qADnhOBICO4qTMiftWjdyReVxeRZjLcKrAeQYBEWmtQtrJ uINpIOdeEYbmIK/voSgjPIa+rIqePvmMvD6Ja8vhUdOD2CKZsQiTuRYjzrYnGeLzM2YKbReq Dsgvav6wDQA0j+Oa+Adwg4tqX41pL2vaOjRSRDKw8s6QGIgz/twLnmEyKA1hNbdz9U278t/U XMjgS8v8yYwrCG4y6Z81WWw4VdmdPnxNcGLMuQivINIjGprgqzfoxuV5CLoThwiuCy71QBls XKvn4bTopOwkKUWlvwjQrm2gHm3jprwWTl00WkjXzqptG8bC4mCuJa7LgpMCfx2g4FhpVRwa hL12WWu958FhXbhhnw4NDOSlVDile0m3w/iuQe5kYvErf2UIUh6bD3wXklV6vpREnBmcYa+a hVfYHhDc9tABanhyuzhBg3/DTENU5DbCtvQSA5y4aoOnZt7ShEJ+Zx/r1Xop46zuNLd3Bz3Z WODk1ZrsA7ciYoV9MKOA4ge7r7NoWfe2OBDIqtSW6XXJ3vfUi98KLK3A==
  • Ironport-sdr: QjbwwAvqVuDUONltbiJldJUWNK/IppM8xqofl5bJB4IWiWVel4B1yymIrRep6Y+hWy1RHPwmBR IkFxdLrli0tCoMwBoR3G+VQeg4fy5a9iMzGMadBhqr6Xca9RuqukkHeqbiCGacvU2EqpXT4zR8 v68QlL2KJL8OdwRPDcIKbGuROV24i0M0GabgbreIzD8DnvPk/5GrBrgIPmo97Jiupk1iwqlluz EPjv31dOrBkbPKtEW53ijSsNYMJiDRUFMQvS8dUYvTroFaJaUP/h5Dy6k5+MAa0k4BtEM76TI3 P6I=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 06/07/2021 13:00, Olaf Hering wrote:
> Am Mon,  5 Jul 2021 08:39:52 +0200
> schrieb Michal Orzel <michal.orzel@xxxxxxx>:
>
>> Modify type of hsr, cpsr, spsr_el1 to uint64_t.
> I think this is now commit 918b8842a852e0e7446286f546724b1c63c56c66, which 
> fails to build:
>
> ...
> diff -u reference.size tmp.size
> --- reference.size      2021-06-29 10:50:32.237518309 +0200
> +++ tmp.size    2021-07-06 13:58:19.052592351 +0200
> @@ -4,8 +4,8 @@
>  start_info                |       -       -    1112    1168
>  trap_info                 |       -       -       8      16
>  cpu_user_regs             |       -       -      68     200
> -vcpu_guest_core_regs      |     304     304       -       -
> -vcpu_guest_context        |     344     344    2800    5168
> +vcpu_guest_core_regs      |     312     312       -       -
> +vcpu_guest_context        |     352     352    2800    5168
>  arch_vcpu_info            |       0       0      24      16
>  vcpu_time_info            |      32      32      32      32
>  vcpu_info                 |      48      48      64      64
> gmake[2]: *** [Makefile:24: check-headers] Error 1
>
> osstest may catch this error as well.

I've just reported the same on IRC too.  Gitlab is currently a wall of
red from 07d6dd51a5c508cc0f3c93a876f8b4e3102ecf60 so won't usefully
highlight this, but OSSTest ought to notice in due course.

Of course, there's copious quantities of information about what this
check is actually trying to do, and why it's present...

~Andrew



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.