[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Ping: [PATCH] x86: drop a bogus SHARED_M2P() check from Dom0 building code
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 6 Jul 2021 09:37:19 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fC8tvz9K5QTmqAfOBdH/A5HhYPvREcEq76jcwFwI4gg=; b=bwzFhzHvack+BHcHIcvKunQH3YZ7ZeaFGp1eRrIBqtl/kOy/DVhfhtflykLow7sWeNBxCJkC9KAcAuO7S1KGCp7A/CdWO/VI+s9uNvrOPNowSaOZrEdirelQ9ALw84FjRqX0Cu156CziuGW2wkSKTlXuWe1IpI+mQya14YC0kVoqDDIG3xlxN8EgJ75ZZgo0aog4p1L3EWRLjVXEymVkAQXoUL0QFn6yVB64mtV4WZiPHOEGj76gsWYwOzzd6CtUPZvZSGrOuShpBWVY7ilHNvb9xOgTMHxg7Hwf1uZ2OCWau5EU8T2K5D8nCInxGoscCni/rtzDcjU4NHBr5Rc/cw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UYDT4qLGln34UxnkIpGAjc5TC8pPalhVdJ6aKJF7/A4lb943DCzXiQg1JJsXmq4JAcFykHHWrdKdBvi1igpVMEQ6GvKzAr794EomURvomRzkhG2Dq6EoQg/E1X45CfPo1YN+h9BssSSXdpML5f12a9JfcXde2VMbrZt70G6O5dkUX6IBc8NIlBLVwV2JobfXWuiiPzlRhNmhWK4nMPOZM2rfM8d4nuZ84DBmDWq0Xybjq0Za0WHiDikjKMpR8rvG1c3cwh7qyp9wlgZAQDqXCwDm9b5ci7HqJPyCb5yZw3F0G+Eu7Tzz0yXSDwutgkaFYtu2L+du4upIGpr5gP6YzQ==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 06 Jul 2021 07:37:27 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 28.06.2021 13:52, Jan Beulich wrote:
> If anything, a check covering a wider range of invalid M2P entries ought
> to be used (e.g. VALID_M2P()). But since everything is fully under Xen's
> control at this stage, simply remove the BUG_ON().
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
I didn't expect this to be controversial, so may I please ask for an ack
(or otherwise)?
Thanks, Jan
> --- a/xen/arch/x86/pv/dom0_build.c
> +++ b/xen/arch/x86/pv/dom0_build.c
> @@ -815,7 +815,6 @@ int __init dom0_construct_pv(struct doma
> page_list_for_each ( page, &d->page_list )
> {
> mfn = mfn_x(page_to_mfn(page));
> - BUG_ON(SHARED_M2P(get_gpfn_from_mfn(mfn)));
> if ( get_gpfn_from_mfn(mfn) >= count )
> {
> BUG_ON(compat);
>
|
