[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3] tools: unify page type checking in save/restore
- To: Olaf Hering <olaf@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Mon, 5 Jul 2021 19:29:58 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SNRljlSzz5o0A/b4RbsPTwoYjOO1FVIs86J6blI1ZM4=; b=biTbCgIbnBMkfNKWvoKB+8GjBXDqv57mC8oH4EmIxxsmCCk0uszWqdNeis58LvK42HgE76M5mZe1RhXtEerr41eHBbg4RDjUKrwYyuBJxa37gONyFcjURvBh2/sjRBVdi0MIsWsvhUnC+jPAvfmJDX6OUFVVCzAA3SR5nNgDsJD65TQJQai7R1ifSAJI6mfDYmRZMQ6w/DTILD8/zEe6diOL+EnKs5ndPTUG29VOnJa7gvMjCwSRFSgKgcWDKy79Mtb7aFXUsuwOf7m+EmDSVdYoSmjv0+jX1ANkVW5gwO6h6I8UncuUodkg8gWBQ4+P3+flf39c3npgjWJqR1UxQA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ap79JJc/3sL2XM7jk/lsuHXvOZfuE/OqrAVDcglox4RXTsLRCA0ZeOkeem0OVQuxn19irgA8EFESKaQ2oMhJT/ZvmFKF6NAgvNeHRStdfX1wYSHaU99uF/c7oJkUNf9gaI1wlnoaVMZGNhptZeGLh1jhSd+5FW4C2CWNjLFuM4dv0zdcDkP1ONKpY5guMPD2SS1s+ZkTaRY4KBHt6KoLCb/Wtm8Yn8NiEMQG5YhH0Yw0ORvSvBYGx3posaAra005oQzGAbr+qPoCPc/EuapEphRpf45oShMM7XbRuPGXutheq0rZZOVhj9kJPwkZ4oTjEVkb1STSEN7F2YFKdO/W3A==
- Authentication-results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
- Delivery-date: Mon, 05 Jul 2021 18:30:31 +0000
- Ironport-hdrordr: A9a23:EfuAv6kh6NKp6BCXlY028cJcVWvpDfLW3DAbv31ZSRFFG/Fw9/ rCoB3U73/JYVcqKRUdcLW7UpVoLkmyyXcY2+cs1NSZLWzbUQmTXeJfBOLZqlWNJ8SXzIVgPM xbAspD4bPLbGSTjazBkXSF+9RL+qj6zEh/792usEuETmtRGt9dBx8SMHf9LqXvLjM2fqbQEv Cnl6x6jgvlQ1s7ROKhCEIIWuDSzue77q4PMXY9dmcaABDlt0LR1ILH
- Ironport-sdr: iuxNDfQKVXqHBa+css/9udJYtyeGX/ifvc7FYVlr6CHl+lhBJGjElsZxMAgvHusV5VU8rNv4jI 6rxsCs7XeF+8wSL/9PfIRhryrmG/OX+TIGLaNhFokSRXkw0BwX+X5Am3FeVJjP0JrFML+wTPR4 DJjJSUDH4LQHKjv9NOzht7Y3PuFVsoFeemrstQ/JN/6/dWjS73wpQI4jfxG3FZmYuH/SUcrdrA Y0QE2lw9xnPEmIx5AGyQmXb7qoDVcGlbAqnHdva0gxyg6JLGHEssytysC7natigPUm9txW+9Ge aXE=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 05/07/2021 17:56, Olaf Hering wrote:
> Users of xc_get_pfn_type_batch may want to sanity check the data
> returned by Xen. Add helpers for this purpose:
>
> is_known_page_type verifies the type returned by Xen on the saving
> side, or the incoming type for a page on the restoring side, is known
> by the save/restore code.
>
> page_type_to_populate decides if a page with the given known type
> needs to be populated on the restoring side.
>
> page_type_has_stream_data decides if a page with the given known type
> needs to be send, or if the stream on the restoring side contains a
> data page.
>
> While touching the code, simplify the logic check in populate_pfns.
>
> No change in behavior intended.
>
> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
>
> v03:
> - fold all three helpers into a single patch
Sorry - I didn't mean fold all 4 patches together. I meant fold
specifically the first two patches together, so the new helper and its
users are in the same patch, as you'd done for the final two patches.
I've still them unmerged in my branch. I'll fold in a few tweaks from
here and commit them as 3 patches.
~Andrew
|
