[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [PATCH 2/9] xen/arm: introduce PGC_reserved


  • To: Julien Grall <julien@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, "jbeulich@xxxxxxxx" <jbeulich@xxxxxxxx>
  • From: Penny Zheng <Penny.Zheng@xxxxxxx>
  • Date: Mon, 5 Jul 2021 03:09:31 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9xVWplOtYYC77d8mpvdrZFeZ/VyCcv1cqSvaZfi6Ieg=; b=L7cC3f+feDMKAxguBPNPNyqydLwjFVxekOUiqe4f/BjbKr88BjvxIr/Ui7AlGt9bSyqApnV6UVGpkz+P7BuWIBkS0NBetyQJz3kGfiSiHHfvL310hofGGVLtnxeP7E1MU3aobGEs9xdar/gc3ZUrK2/XgKRzuCpBYegQg9YyqdyotKiHqn9Vzbje5CD1Dp5zKVQV1HgulSZj49TLDwtSLA5qkLsikOMO6QJWa4zo0mW+x1q6zzUe0bxeSPGVGLt+Bje8cukFhxLlCHQqYy0FYylv5WKv3FXJjG09rbjZoFrVtUvYAuR3WJiPMRhM2yuvi4dk56+dTNMgRTi6ITVjSA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mNUMXFM+0MT/PkCH0pWa57hQxQ/QyCqWTAyxm5nv3XlbgfR83ut+mLEj9bI59fYXlSU5zv2EsoiLGEGHlf3O2Zp1g50MR2Jm+mV749xSPg7SPASdhnZtG79dXM4Usont1aCa36hrT472cgIm9CejB4sst2EBW1rcxpgcHe32LsMe/hEopV4jodcyVe4KT+s9tyAjRLewR/u3IJQd90ytMi0SBB2FDd+2r86649bMhet6iHutFOiCVuCz5oX6cEawPqYNMfS42xc5fTLd68yGZk5QHJRTYQxHT/7ZqxhNKFq4HaI/uH6KJtqKP8UXwXFKHRsWOLYDBIl2kvimD29HcA==
  • Authentication-results-original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
  • Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>
  • Delivery-date: Mon, 05 Jul 2021 03:09:57 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHXW0bwHTQXl1IIhEKAMxa4O5onFKss+IkAgAbmToA=
  • Thread-topic: [PATCH 2/9] xen/arm: introduce PGC_reserved

Hi Julien

Sorry for so long to respond, just back from a long holiday. 😉

> -----Original Message-----
> From: Julien Grall <julien@xxxxxxx>
> Sent: Thursday, July 1, 2021 1:44 AM
> To: Penny Zheng <Penny.Zheng@xxxxxxx>; xen-devel@xxxxxxxxxxxxxxxxxxxx;
> sstabellini@xxxxxxxxxx; jbeulich@xxxxxxxx
> Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>; Wei Chen
> <Wei.Chen@xxxxxxx>
> Subject: Re: [PATCH 2/9] xen/arm: introduce PGC_reserved
> 
> Hi Penny,
> 
> On 07/06/2021 03:43, Penny Zheng wrote:
> > In order to differentiate pages of static memory, from those allocated
> > from heap, this patch introduces a new page flag PGC_reserved to tell.
> 
> I would prefer if this patch is folded in the patch first using it. This will 
> be
> easier to understand how this flag will be used.
> 
> Cheers,

Sure, I'll re-organize this commit.

> 
> >
> > Signed-off-by: Penny Zheng <penny.zheng@xxxxxxx>
> > ---
> > changes v2:
> > - remove unused reserved field in struct page_info
> > - remove unused helper page_get_reserved_owner and
> > page_set_reserved_owner
> > ---
> >   xen/include/asm-arm/mm.h | 3 +++
> >   1 file changed, 3 insertions(+)
> >
> > diff --git a/xen/include/asm-arm/mm.h b/xen/include/asm-arm/mm.h
> index
> > 0b7de3102e..7034fae1b6 100644
> > --- a/xen/include/asm-arm/mm.h
> > +++ b/xen/include/asm-arm/mm.h
> > @@ -108,6 +108,9 @@ struct page_info
> >     /* Page is Xen heap? */
> >   #define _PGC_xen_heap     PG_shift(2)
> >   #define PGC_xen_heap      PG_mask(1, 2)
> > +  /* Page is reserved */
> > +#define _PGC_reserved     PG_shift(3)
> > +#define PGC_reserved      PG_mask(1, 3)
> >   /* ... */
> >   /* Page is broken? */
> >   #define _PGC_broken       PG_shift(7)
> >
> 
> --
> Julien Grall


Cheers

--
Penny Zheng

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.