[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Ping: [PATCH v4 3/3] unzstd: make helper symbols static

  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 30 Jun 2021 09:43:49 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l3FgzD2nb1eGianYjmDXgYghYrlnkqyxQmlsrx7Fo7E=; b=lmjDcCVUG5QH6c8NMrWaOX0ncP6fgSu+07g0zSH2IzHVLbke6u3KmaGHeD23Hu4gRvhoNn8E/7tjkGkf7BBXnh2KNpolGUqJ1BpOx1+igQV4vD8lw9U541/ZAjkexkEpNCqa4Nui5ITxMnKN75clNBunEiskKeQkjxcVARGVE7OYWazVPW8M7IjgC65zIXBGTit9HH7iyK01CT9B2HJDMCZfu5HLXd8rVgXiEqOi0+rKUmtQWZxLqG407MlsN6tUZyMOS4dhPwAhPrZ9J4TM9bSTR46psOEft9av14KxlWCpD0OvMzDr5HN+7juOSAQvIKDDJlJ92040KT0WsAJItQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FYPfHlSFOIc0t9YKZCWNq94cBQagNCHjcd759xvdDzc9uua5nI6Of3DXvY0EUDOHzO6ELsq+C4rGWnZ931YQh0arhW42yiNhR8ApEunct01MIcP3I2uw0rGLrHLrmVg5nYkrPR6lG+5IvkJCTAD1wq1spnYM3cCgiBIyphGwTUIyj9QKyoQXG6cNxcUIkc7NrfMqWIzy6m0LsAyhirhDYrx9s1McusVC2LVYhQg1RtghlVqQqqWZfoSG6whS2NkukBWnP1Yh+zapLaWZm6/caRjPinAC/hXZOaJ8d1lS75s5R2GqnwOS/+0k/tlsVZ109pb/lAHHgJe70lUqftAGyA==
  • Authentication-results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=suse.com;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>
  • Delivery-date: Wed, 30 Jun 2021 07:44:09 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 05.05.2021 19:35, Julien Grall wrote:
> On 29/04/2021 14:26, Jan Beulich wrote:
>> On 29.04.2021 13:27, Julien Grall wrote:
>>> On 21/04/2021 11:22, Jan Beulich wrote:
>>>> While for the original library's purposes these functions of course want
>>>> to be externally exposed, we don't need this, and we also don't want
>>>> this both to prevent unintended use and to keep the name space tidy.
>>>> (When functions have no callers at all, wrap them with a suitable
>>>> #ifdef.) This has the added benefit of reducing the resulting binary
>>>> size - while this is all .init code, it's still desirable to not carry
>>>> dead code.
>>> So I understand the desire to keep the code close to Linux and removing
>>> the dead code. However I am still not convinced that the approach taken
>>> is actually worth the amount of memory saved.
>>> How much memory are we talking about here?
>> There are no (runtime) memory savings, as is being said by the
>> description. There are savings on the image and symbol table sizes
>> (see below - .*.0/ holding files as produced without the patch
>> applied, while .*.1/ holding output with it in place), the image
>> size reduction part of which is - as also expressed by the
>> description - a nice side effect, but not the main motivation for
>> the change.
> Thanks for the providing the information. I have misunderstood your 
> original intention.
> Reading them again, I have to admit this doesn't really change my view 
> here. You are trading a smaller name space or prevent unintended use 
> (not clear what would be wrong to call them) to code 
> maintenability/readability.
> At the same time, this is not a code I usually work on (even if I am 
> meant to maintain it). I will leave another maintainer to make the 
> decision here.

May I ask for another REST maintainer's view here? If there's support
for Julien's position, then I'll at least know to drop the patch. Of
course I'd prefer it, or a stripped down version of it, to go in.

Thanks, Jan



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.