[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/4] tests/xenstore: Rework Makefile
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 28 Jun 2021 14:52:29 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yVJNCo1sNX/APcKFoae9hxZ2G4hFWbGPjS/ATQ26mDY=; b=aeKBxEtnOuCvHQ6p5K3YQyyFx/2v+HeIby8rD3/WGsgDWx5ixOqbK/mKxPGAbksOgDViYU60z7JdsfBtPGCdDVQdo/5EkUY7lSk8WXir34CH89xFukIr6H/iWN1W6zcCPxFJ+ACl7Oh9vH6jdsDxscVKvHFAXpLrLIWXewdcULTOyHi2JpJDcM0XFvkn2JCACcOtXvuhnxb1nbmwEBq6MXRQmp9qzjeY/gKQ1V+m4Fe5gPRO7c83wzOi9xIOh0vfEQ1tlU+mZSkOS7ve/qdfp2OXQvGFmVWSsIXoBh7ieUoi1iyOYeq1tB1gQDz7Io8YUmSyyc61qDqfq6Mo2UD4qw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ehghYznthXVfKfH8EQjcgMq3kG4vZG+1hUVZ/P3iQGYXwY0539XL1nwfnzY9e8uEDsMDc3KGiD/m7jxGa5MlkzbQa1C2eRPbctd2x+PGw4UxyEb4FOCfWjab/o5Z6zF9R6o/lGw4ktPY7cnrKIYqcRUEvXFsHo28DnaJx3YpuFZWMO2wrArlWbBowuhyA+amDKAVWykU4wK4GQSwT0HAn5J3jiEEcaV5VgBkybYUGgfHreI6/Znz3DKobR9i1uwV8e0jH6vvhSj1Ab/t8ddpThbwa+u3ZgL1wNLcavlIMOpYfS6uaAvWz5KbN6k85D2CyIHHMPv9DktCp2+6OFE8RA==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
- Cc: Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 28 Jun 2021 12:52:38 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 22.06.2021 20:21, Andrew Cooper wrote:
> In particular, fill in the install/uninstall rules so this test can be
> packaged to be automated sensibly.
>
> This causes the code to be noticed by CI, which objects as follows:
>
> test-xenstore.c: In function 'main':
> test-xenstore.c:486:5: error: ignoring return value of 'asprintf', declared
> with attribute warn_unused_result [-Werror=unused-result]
> asprintf(&path, "%s/%u", TEST_PATH, getpid());
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Address the CI failure by checking the asprintf() return value and exiting.
>
> Rename xs-test to test-xenstore to be consistent with other tests. Honour
> APPEND_FLAGS too.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
|
