[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 02/12] libxenguest: deal with log-dirty op stats overflow
- To: Olaf Hering <olaf@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 28 Jun 2021 13:20:06 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ycMBJMYx+bo33iul5PhArutVOlVjHEdt6VKnSuDkl/Q=; b=Vrmy6jbi1wJe1EB6cBfjlro30mmZzehttaG7LE6gfsnUxYF1BgldgJYmdqM1IOEugAD2mgU99rLzmlhgFnosZy98pYnA733L/nO13zj7wODc1qDImfXPb6pj4gTfFaK8N/VceOdzk11jIv7763LLtwlz6Rl8+kpcSKbagJ1l+hIw8MOHhVOLeXqDk5arXOTn98WoQ03gQBH4Z3MiuAtBJR9PPBm2jzRcadg6Io9+uOrcSELN9kw7mNY2PpTQy+EbTpLEpzpSGWUfF0eTyCua0v08NLlM5FhQTmkAYqVMYYcpvszLYqLat1KOiLD6wU1mYsWED57lhXDYVrWsoH2BMg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e7OZkDApT+9k+16nByHbEvPy6jAvh7ZJjR2FzwbBENjhG5hQucH+0mK0VVtlS/AI8KQZEvwMP8Ch9fT5xKqWBt+WFJRlgzqVnds/8OpG8Bx/2/j5vSC0/oogejIaGGQtM5qZYN6jKFnZnBr29PEkVPPDb/2iu4toomYYD2e7cyWmDjo363ZvIsT7QMRppg4esdbjhArfvvDzi5282w2CsRKrQCrMueony1DalQsAI8PsDLeXo+TetCjQMV8rReDMRtVl325FnrNBftYNQUKUNptkKP3fgc2wCebz5nB6UWtLAmr9YcpFdQNpjkSKNontLZ27GH2o1/pxxL/acW0+dA==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 28 Jun 2021 11:20:17 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 28.06.2021 13:10, Olaf Hering wrote:
> Am Mon, 28 Jun 2021 09:48:26 +0200
> schrieb Jan Beulich <jbeulich@xxxxxxxx>:
>
>> On 25.06.2021 18:36, Andrew Cooper wrote:
>>> This is an external interface, and I'm not sure it will tolerate finding
>>> more than p2m_size allegedly dirty.
>> But you do realize that a few lines down from here there already was
>> policy_stats->dirty_count = -1;
>> ? Or are you trying to tell me that -1 (documented as indicating
>> "unknown") is okay on subsequent iterations, but not on the first one?
>
> precopy_policy() gets called twice during each iteration.
> Last time I tried to use this API it was difficult to work with.
> It is required to look at dirty_count and iteration to see the actual state.
> Maybe it was just me who initially failed to fully understand the intent.
>
> I think as it is right now, the first run with iteration being zero is
> the only way to know the actual p2m_size, in case the consumer really
> wants to know this detail.
But if a field named dirty_count was intended to convey the P2M size
(and then only on the first iteration), this very certainly would
have needed writing down somewhere.
Jan
|
