[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 08/12] x86/paging: deal with log-dirty stats overflow
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Fri, 25 Jun 2021 20:09:11 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oYGAbKx6nYxEdmQxP42MpwAMSnLTujWNfpB4WJdDm94=; b=Q/BG2cqXQonj6P0QjBE3h7aU969+zJkfFN56/hJx1HXzPWueaNGp/DB3+NaLYfvyhI1WOohHXVTI5OiQ/XuTcBIDhhc9tJdksu+4QX6IBuBlNSC/8Iq/Gtdgn9Q7X5sjpZ2IKNgwAeY6MlpURj1I8PvldsGPozlnwRVRWgzOn1uvgZJOpjCfp1kyO5CNuuIllqm9t3/AFKT5hX+rSVls5yhB+Il2aY1lHsKdRME6iAPJ6aunwFuk8hjyHHxMw7EKOl8tQj1HHPQWpAhcmADV3BF8t17yQ7ahG0QXq6JNc5Bh2OSXY304FxTAkHYEK0N72g7g4NuIv16PZiUfKJfbbQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ja+ZmAjPcoCMx75UPeXGVYP4UwztiK52LIkc71HjjZNehtAM0Md/OHdE2UOfPTDCPm5X8RkgzHd6JEjXhbaL5xqVL3BUFl4J68eeTnOHsNcY0Cv6lrrsHcYIQ+AOpsHywWM7nETi/m3fWZR8aurC7LT0yPvZptqzlRK++n4wl3k/+vMmmWm1mJbG8oM94FrkjEioIzPrHnHaMHQD+cx6al8CdZZ0x1bUjduDBR8sVx766IG4A/Cc2slMD7tv4lzcqAZvYqR5G1v6tsa4+5m4tAA1TxWpTlerEJ6SnKICFBMmi6/dolYdeD6yi2YI11moE+VOwKMbjjoq+ytFpc1HBw==
- Authentication-results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>
- Delivery-date: Fri, 25 Jun 2021 19:09:27 +0000
- Ironport-hdrordr: A9a23:0FuVlalePM9EfoGfCTFmgbncDBjpDfLW3DAbv31ZSRFFG/Fw9/ rCoB3U73/JYVcqKRUdcLW7UpVoLkmyyXcY2+cs1NSZLWzbUQmTXeJfBOLZqlWNJ8SXzIVgPM xbAspD4bPLbGSTjazBkXSF+9RL+qj6zEh/792usEuETmtRGt9dBx8SMHf9LqXvLjM2fqbQEv Cnl6x6jgvlQ1s7ROKhCEIIWuDSzue77q4PMXY9dmcaABDlt0LR1ILH
- Ironport-sdr: JT5X98sikgoIM5P+NMLKwMwvUvk9fb38SrX4SE7KmQdvSYj7KUspWYIJxuugYZPaTUuYFo9XbH oWU9DRgBhghbDL0pBQmQpmId+s2x09GbAdckndlCNScfjyQXUw+Tcm4elLx0jkHTP3TqNLBDLm xQaHE4/O6aXfYBrjrD5dyh7r1yGTdUQ6E8U6qXIpGsSXTndMFsQB8NJf+7LyynGOm3kexFsbd5 vPL9qDScEuhHA2OjajHtKBPcfSXWezsDlA8NLpR1tTpU3C/DOM0pvep8AjC+4oscPdqKjkJDwK tQI=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 25/06/2021 14:21, Jan Beulich wrote:
> While the precise values are unlikely of interest once they exceed 4
> billion (allowing us to leave alone the domctl struct), we still
> shouldn't wrap or truncate the actual values. It is in particular
> problematic if the truncated values were zero (causing libxenguest to
> skip an iteration altogether) or a very small value (leading to
> premature exiting of the pre-copy phase).
>
> Change the internal fields to unsigned long, and suitably saturate for
> copying to guest context.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
|
