[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 2/2] AMD/IOMMU: re-work locking around sending of commands

To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
From: Paul Durrant <xadimgnik@xxxxxxxxx>
Date: Fri, 25 Jun 2021 15:13:05 +0100
Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Delivery-date: Fri, 25 Jun 2021 14:13:11 +0000
List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 25/06/2021 13:15, Jan Beulich wrote:

It appears unhelpful to me for flush_command_buffer() to block all
progress elsewhere for the given IOMMU by holding its lock while waiting
for command completion. There's no real need for callers of that
function or of send_iommu_command() to hold the lock. Contain all
command sending related locking to the latter function.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>


Reviewed-by: Paul Durrant <paul@xxxxxxx>

References:
- [PATCH v2 0/2] IOMMU: XSA-373 follow-on
  - From: Jan Beulich
- [PATCH v2 2/2] AMD/IOMMU: re-work locking around sending of commands
  - From: Jan Beulich

Prev by Date: [ovmf test] 163028: regressions - FAIL
Next by Date: Re: [xen-unstable test] 163021: regressions - FAIL
Previous by thread: [PATCH v2 2/2] AMD/IOMMU: re-work locking around sending of commands
Next by thread: [xen-unstable-smoke test] 163033: tolerable all pass - PUSHED
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.