[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH V7 01/18] perf/core: Use static_call to optimize perf_guest_info_callbacks
- To: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>, pbonzini@xxxxxxxxxx
- From: "Zhu, Lingshan" <lingshan.zhu@xxxxxxxxx>
- Date: Wed, 23 Jun 2021 17:06:36 +0800
- Cc: Like Xu <like.xu@xxxxxxxxxxxxxxx>, Will Deacon <will@xxxxxxxxxx>, Marc Zyngier <maz@xxxxxxxxxx>, Guo Ren <guoren@xxxxxxxxxx>, Nick Hu <nickhu@xxxxxxxxxxxxx>, Paul Walmsley <paul.walmsley@xxxxxxxxxx>, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, kvmarm@xxxxxxxxxxxxxxxxxxxxx, linux-csky@xxxxxxxxxxxxxxx, linux-riscv@xxxxxxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, "kvm@xxxxxxxxxxxxxxx" <kvm@xxxxxxxxxxxxxxx>, bp@xxxxxxxxx, kan.liang@xxxxxxxxxxxxxxx
- Delivery-date: Wed, 23 Jun 2021 09:06:56 +0000
- Ironport-sdr: rP8uekMS6K6bv8j+KZX8YdnQ7UWdg1QfG6KloBMeZFiWjHEp+U6iLhZw7vXOQZJFg5EpLLIapF lN3ojr528o1g==
- Ironport-sdr: g2eO6eKo7NA4GY19a7CouO+5j1o7GAnTSLroawrK3+rYpOJrEVfMjr60J7q5kjcIpvJfXcjBDr 3E4HH0+4OM1A==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Thanks Boris, I will fix this in V8
On 6/23/2021 1:31 AM, Boris Ostrovsky wrote:
On 6/22/21 5:38 AM, Zhu Lingshan wrote:
-static int xen_is_user_mode(void)
-{
- const struct xen_pmu_data *xenpmu_data = get_xenpmu_data();
+ state |= PERF_GUEST_ACTIVE;
- if (!xenpmu_data) {
- pr_warn_once("%s: pmudata not initialized\n", __func__);
- return 0;
+ if (xenpmu_data->pmu.pmu_flags & PMU_SAMPLE_PV) {
+ if (xenpmu_data->pmu.pmu_flags & PMU_SAMPLE_USER)
+ state |= PERF_GUEST_USER;
+ } else {
+ if (!!(xenpmu_data->pmu.r.regs.cpl & 3))
+ state |= PERF_GUEST_USER;
Please drop "!!", it's not needed here. And use "else if".
With that, for Xen bits:
Reviewed-by: Boris Ostrovsky <boris.ostrvsky@xxxxxxxxxx>
-boris
|
