[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 05/10] tools/xenstored: xenstored_core.h should include fcntl.h
- To: Julien Grall <julien@xxxxxxx>
- From: Luca Fancellu <luca.fancellu@xxxxxxx>
- Date: Mon, 21 Jun 2021 10:03:26 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NIn4QFZpjWQFUKJu9q89YMpvDVKYdNvpKtom6uEO1e8=; b=VA/UuaPNQ9W2rx+yAREDOQAh/FRnTjxpCJxh4hLzTkznmCb3agOKRxPvaNoF192jKTbou1oAyjJECM4tNKZEp1RbXF5DvKkgQrphO/obrW1M1GL2RlNTy9hYklAwOaja4/aslv0B3bMCQBkQE/RsV5bai3pQzt/bZ12C4rHCI5mjevifNh229I0UDFMXZWy7ycB3JPU5yeSIsx82ivCeVtmAcrCt0c1g8CkNii1m0mAVfiVDCfeCuR6LhOjwVR5Sp0BymVWFTNd2brLFmefnnJ4jPXcRFNkNcrL8v1DxhFXDjnDb7emxKpvYZYeszaLQTEQZj66nfOs78yGSWBgoMg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IMMMIV345Z5wytheB9+VHeSlQtgJHUcc/7NfxbBu97Rv9QAjO6XedTt3uWeMZu12p/U6wo0wWRCLrR6rnLpsi7RZwUM2cmx0WPiE0xiIymuTBWGDyfFmy+zKWKfjFlCzqrX+hZuYZqY8B0T+NjtBUWl54di9wfN/5BuK/tctcC4XyuCnYbYJiEeaZiC08oyX1C+tcFwpPT01Jz64uLrFZbOpTNGZKoxpA7+SKJiVFeFdUSAywynyDsq7RqL9/+0Cg4AEiaMxv3KXvOwDJXsW/COITgk5BzwHoRTgF4mYqSy6eryFJRsaE4uQim0zoNzCA+DlDTaPZfpqA0jjIshf2Q==
- Authentication-results-original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, raphning@xxxxxxxxxxxx, doebel@xxxxxxxxx, Julien Grall <jgrall@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
- Delivery-date: Mon, 21 Jun 2021 09:04:21 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
> On 16 Jun 2021, at 15:43, Julien Grall <julien@xxxxxxx> wrote:
>
> From: Julien Grall <jgrall@xxxxxxxxxx>
>
> xenstored_core.h will consider live-udpate is not supported if
> O_CLOEXEC doesn't exist. However, the header doesn't include the one
> defining O_CLOEXEC (i.e. fcntl.h). This means that depending on
> the header included, some source file will think Live-Update is not
> supported.
>
> I am not aware of any issue with the existing. Therefore this is just
> a latent bug so far.
>
> Prevent any potential issue by including fcntl.h in xenstored_core.h
>
> Fixes: cd831ee438 ("tools/xenstore: handle CLOEXEC flag for local files and
> pipes")
> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
> ---
> tools/xenstore/xenstored_core.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/xenstore/xenstored_core.h b/tools/xenstore/xenstored_core.h
> index 34839b34f6e9..dac517156993 100644
> --- a/tools/xenstore/xenstored_core.h
> +++ b/tools/xenstore/xenstored_core.h
> @@ -24,6 +24,7 @@
>
> #include <sys/types.h>
> #include <dirent.h>
> +#include <fcntl.h>
> #include <stdbool.h>
> #include <stdint.h>
> #include <errno.h>
> --
> 2.17.1
>
>
|
