[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tools/ocaml/libs/xc: add OCaml stubs to query CPU policy
- To: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- From: Edwin Torok <edvin.torok@xxxxxxxxxx>
- Date: Fri, 18 Jun 2021 13:46:58 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H+610r95/mEl0uWAJ5OlOC40N1wDr546XfSq/hoUwqM=; b=H5kCPBeeV+LVTJysco9vxYh8Fnf54ayrGZCwOtIWw24MKAEXELyDGeSAZkpAxz+Uo83CmPSaMNdr0BWHotOMDHu1qlA8+0ShZSyjg3b7EAjzKzOp4jZ3Z0Ziy6MNWtJjzNu2NBklqWA8t6v9b3HE37AiJHO27Drs5YVC9LYFOAB8w6Yuayz/Phrb+g50BaGaGzbfJuPL8FbGBqgemUiqAWHiZGaXQUYY/GKCLHIwxbInERmzwKgC+cbP3Q1cNH/vGVVUnCwnmgBMkZLuz5c0ICAaVQdbwnczvL0SQb3Bo3GJGul72YTuwZhihpYCiIUEx2PdMDJ0CAWlAQ3KNfL7nw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VhZSGVx03O8ee89VreKa3yuVWlBm/n8oP43D6+vCKNG9X0AeofZyH02wlovpVMYI6kISFjpfk9Ecl/auJ6TtSm6ArN6DRu+YQJkUYI2Jxhm1Ro74vQ66TpeSgpqS9hS98FukthgeTFbHw1HY3fE1Lt+ymhInGBvK8djdDvt76+02Z3BteHqyF6rTi3wa5RqZTi+qx1NJotGSUVU3vLUDUQS4COocarXoEpxWhzmSFA8H1RvJ/q4idJ5pD/bhI5+LwiSZZTFRl/qhBzVhwYr1VxVTtimMfkEpYzFhQccCTV4UWO0ngB9TOpt+adm1bUXBB+DKs5afNtZ56WUeuifu/w==
- Authentication-results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Christian Lindig <christian.lindig@xxxxxxxxxx>, David Scott <dave@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Fri, 18 Jun 2021 13:47:04 +0000
- Ironport-hdrordr: A9a23:ZlLsVaCzfS0GWQrlHelo55DYdb4zR+YMi2TDt3oddfU1SL38qy nKpp4mPHDP5wr5NEtPpTniAtjjfZq/z/5ICOAqVN/PYOCPggCVxepZnOjfKlPbehEX9oRmpN 1dm6oVMqyMMbCt5/yKnDVRELwbsaa6GLjDv5a785/0JzsaE52J6W1Ce2GmO3wzfiZqL7wjGq GR48JWzgDQAkj+PqyAdx84t/GonayzqK7b
- Ironport-sdr: gO4jcaCNHacz/TQfRvw/1XvJvn9uPQQIi9L/hM8XcBE/Ul0XQbYwqPtxHAR/dWw94sEcBMwMJk ZEKK5LwKoPmic7v+MuKbPJI87ZWgx/6f4I5oQi0MFfH7QW+PEKz5/r2ghwS8Q0pzfmJOKoGYLE qRF1+lJM5cSQ5DVETKLt+te8Y/iGpcaSVORy5+pOWXYRfwG0ft8ehTA8mXrGBI3U9AEcp4WYdT 12D0ah95qCz1SOe3/sY8I4y0nDBcpoHuWi1m0vdQ3EkOkE48Yv2LJq4tyBuMGotU/E7tNn3YFI XMg=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHXZC8pdx4Fbe3SD0u2mLoPzHVclasZwB4AgAAIUoA=
- Thread-topic: [PATCH] tools/ocaml/libs/xc: add OCaml stubs to query CPU policy
> On 18 Jun 2021, at 14:17, Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx> wrote:
>
> On 18/06/2021 11:45, Edwin Török wrote:
>> diff --git a/tools/ocaml/libs/xc/xenctrl_stubs.c
>> b/tools/ocaml/libs/xc/xenctrl_stubs.c
>> index d05d7bb30e..4a230de8b7 100644
>> --- a/tools/ocaml/libs/xc/xenctrl_stubs.c
>> +++ b/tools/ocaml/libs/xc/xenctrl_stubs.c
>> @@ -34,6 +34,9 @@
>> #include <xenctrl.h>
>> #include <xen-tools/libs.h>
>>
>> +#include <xen/lib/x86/cpuid.h>
>> +#include <xen/lib/x86/msr.h>
>
> https://gitlab.com/xen-project/patchew/xen/-/jobs/1358403495
>
> CI says no. This needs to be behind a suitable ifdef, for non-x86 builds.
Should the stubs be disabled completely and raise ENOSYS/failwith on non-x86
(e.g. ARM), or are there plans on doing equivalent CPU policy on ARM at some
point?
—Edwin
>
> (I've not looked at the rest of the patch yet. I'll get around to it at
> some point.)
>
> ~Andrew
|
