[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: hypercalls with 64-bit results


  • To: Juergen Gross <jgross@xxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Thu, 17 Jun 2021 17:26:50 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pDQwX7dHwh3cGulwT3yX6Ge6wlI9RopclW9K6b0DM2A=; b=gfjk/HEpeH+7AVOtHaFzaHouIcLirlBCP5oruwAbl/K+8rYVqJmryyaCKbleQ4V7LOME0yNEBtgZ5tZJ9D04ArJBx5/W3frtReFwSSyHHc+8pcJdRnekYzaRU/1FssUQjfwCc0OWvE267La6eph8vfykqBZNtQl4Rki8H3horC1lyEqNXVzA1nnaya8tGeU0TlsS2uHCGRE5RPuUJaj+Pt+ZKXjMnhP94PIs+zG0ybMKQmosR6f1NiaUJyPe3OJ0t/EI5zOqT6wuYJcnPuzApWRboW3Ns4diVNZ8QoeSOm27rdMZ7ePSvU5mH9+5RAFPG8ZUR8QdSzU6y+NIScp7vw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dwoXRd8xSJEWixeqMokhaA7JKa4R+UOE1f0SZaDpteoMwuo2kuvDWpf8mYdTRSlTivNe6FQxPllkOX8Gs2VFbUBzKNkkUMRq8jA/I6jFgeMldhxKEgoKKpSMuEMDsrKQBpp+7vLxwsAyUMxbo8qvWaTMHXSnHjdHD7Eu8Omv+q1lQcxjeoFB8QtMXulU/oicYQGCnJetMXHg1wxEhtRY3KR32CJ0UhdmWfrpsxCysmLFOcuZHr6tlQ3JTE8RG2xMGI8zuTXrpZcrZ9rMEhMOgUPN8S6k1RrxhrU2Qm8UlWLEeDBYij++/2mrdDiB61XHnWTsrNeP1ijlD+JQFd/8Dw==
  • Authentication-results: oracle.com; dkim=none (message not signed) header.d=none;oracle.com; dmarc=none action=none header.from=suse.com;
  • Cc: Anthony Perard <anthony.perard@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Wei Liu <wl@xxxxxxx>, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
  • Delivery-date: Thu, 17 Jun 2021 15:27:06 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 17.06.2021 10:08, Jan Beulich wrote:
> On 17.06.2021 10:05, Juergen Gross wrote:
>> On 17.06.21 10:00, Jan Beulich wrote:
>>> On 17.06.2021 06:55, Juergen Gross wrote:
>>>> On 16.06.21 18:04, Jan Beulich wrote:
>>>>> Since hypercalls from the tool stack are based on ioctl(), and since
>>>>> ioctl() has a return type of "int", I'm afraid there's no way we can
>>>>> deal with this by adjusting function return types in the libraries.
>>>>> Instead we appear to need either a new privcmd ioctl or new XENMEM_*
>>>>> subops (for those cases where potentially large values get returned).
>>>>
>>>> I think we can just use a multicall in libxc to wrap the affected
>>>> operations.
>>>
>>> Hmm, we might, if we're happy for these to then not work in HVM domains
>>> (PVH Dom0, which still is experimental only, or PVH/HVM DomU-s using
>>> the libraries for some purpose), or if we finally wire up multicalls in
>>> the HVM case (there ought to be a reason why they aren't, but I have no
>>> idea what that is).
>>
>> Me neither, especially as on Arm they are supported.
>>
>> And TBH: PVH Dom0 without multicalls might be hard anyway.
> 
> Okay, let me see whether, while trying to wire them up, I run into
> particular issues.

And, at the risk of stating the obvious, this isn't going to help 32-bit
Dom0 at all, so (assuming the immediate issue wasn't going to be taken
care of at the ovmf side) would help only one of the two tests preventing
a push right now. (I have a patch set drafted, but it's yet to be tested.
I did find though that the tool stack already uses multicalls in one
special case.)

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.