[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] swiotlb-xen: override common mmap and get_sgtable dma ops
- To: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
- From: Christoph Hellwig <hch@xxxxxx>
- Date: Wed, 16 Jun 2021 16:21:48 +0200
- Cc: Roman Skakun <rm.skakun@xxxxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Christoph Hellwig <hch@xxxxxx>, Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>, Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>, Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>, Roman Skakun <roman_skakun@xxxxxxxx>, Andrii Anisov <andrii_anisov@xxxxxxxx>
- Delivery-date: Wed, 16 Jun 2021 14:21:54 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed, Jun 16, 2021 at 10:12:55AM -0400, Boris Ostrovsky wrote:
> I wonder now whether we could avoid code duplication between here and
> dma_common_mmap()/dma_common_get_sgtable() and use your helper there.
>
>
> Christoph, would that work? I.e. something like
You should not duplicate the code at all, and just make the common
helpers work with vmalloc addresses.
|
