[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/5] tools/tests: More cleanup for automation improvements

  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Wed, 16 Jun 2021 14:22:13 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KQeKuo84mnXecHW3LWCCXtrgaV/RyUvoutWimsrj0d4=; b=gvCWHiDkgF4MyzVXryeOFHQA41EPzByi0RsmSTzqqhCsKGpf7ppfhaQaE1hyCIm4NUzv827fiy9JaYFqNWbNBAIO+1QGDK+8GohY+rILGBszpFPSPL2bZ5f4JX86mShBOnmnRFFscvyJWKVBDWBPvxRXLnSj/cuBW1OFRApVExK5WX5baAktpHqaRDFEPcWpn85bnWAOEnz14bBUNnlXerFPZ0QG/w2y9On+mWAf5t7OGbGwXe1mOmWj8nWGllTiQx6GZi+E2HQXGO1pnS8jm8C83oG6xcqsfvPTEbKhSnPQMWQB9prLPhdBeYeKbl5+nuEDvcMI6bjz9X4/zd31aw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MNrtK6gRuF+f7aGCQS+evzCeFANo8RXmopOhWYx8useNVWjCSHGQo9ybZvVhWYOSbX1nqTD2eYc002zG6ANf3MaW0NAEmFpla+HNzFLVmIMghdnZy+KwY2OPKcNDq63F/oCYFZIYnvpqgLcIw7KGkra8cmx4u648JYFXieALEXvy8Wh/L63HQhKbry9LS1cQYqTquM9sfrnrE42MrlLxRIsQkzqFVGbm3nSbr1XJFg23N5MthSJOgxTPI7AiHjaAZExjizhNo89SjtzNhR8mjFMmjn4axgoSAlwXLOYyN5BJ4eSZ4IxL6D+aSSn05azoDzRLlcqShSQJqeC9HeaSlA==
  • Authentication-results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Wed, 16 Jun 2021 13:22:40 +0000
  • Ironport-hdrordr: A9a23:MEciTK21SQ8p29rzM9reegqjBVByeYIsimQD101hICG9Lfb2qy n+ppgmPEHP5Qr5OEtApTiBUJPwJE80hqQFnrX5Wo3SIDUO2VHYUb2KiLGN/9SOIVyHygcw79 YGT0E6MqyLMbEYt7eI3ODbKadY/DDvysnB7o2/vhQdOD2CKZsQizuRYjzrYnGeLzM2Y6bReq DshPav6wDQAkj+Oa+Adwg4tqX41pL2vaOjRSRDKw8s6QGIgz/twLnmEyKA1hNbdz9U278t/U XMjgS8v8yYwrCG4y6Z81WWw4VdmdPnxNcGLMuQivINIjGprgqzfoxuV5CLoThwiuCy71QBls XKvn4bTopOwkKUWlvwjQrm2gHm3jprwWTl00WkjXzqptG8bC4mCuJa7LgpMCfx2g4FhpVRwa hL12WWu958FhXbhhnw4NDOSlVDile0m3w/iuQe5kYvErf2UIUh6bD3wXklV6vpREnBmcYa+a hVfYHhDc9tABanhyuzhBg3/DTENU5DbCtvQSA5y4aoOnZt7ShEJ+Zx/r1Xop46zuNLd3Bz3Z WODk1ZrsA7ciYoV9MKOA4ge7r7NoWfe2OBDIqtSW6XXJ3vbEi91aIfpo9Fv92XRA==
  • Ironport-sdr: SWT2nxb+TGHzuw8JlO0gbLyqtF5DrsRqhjSnMFHyv1DEb/4GB866O2O5AiegrwOJ39YeiYeDE7 pDmyM3AxPlcAKYTTTccigshraPpDA02sF4Cc0z9DggrxmqZWpDUegdUxp4Z6cEOIH9jlwnlk4o u1CUokmswqyq8GkQuKGbqWmv/bq6rVGljg6ZGTf/VGlt901tIky0+8abPffjNFV1kztXjOQS1p HD/3YIDcFRYv099fZDaDerhlbUQYucofnEaNLoOYGW2ooT3r+FHNS/q0p9zCNnWgPKLULcv99x jkQ=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 16/06/2021 07:38, Jan Beulich wrote:
> On 15.06.2021 18:19, Andrew Cooper wrote:
>> Jan/Roger: x86_emulator and vpci use $(HOSTCC) not $(CC).  While they are 
>> unit
>> tests, we still potentially want to run them in dom0 rather than the build
>> environment - particularly for x86_emulator which is heavily CPUID based and
>> wants to run on a wide set of hardware.  Any issues moving them off 
>> $(HOSTCC)?
> Well, yes, I'm afraid: If anything, we may need to build two binaries,
> or build the one binary two different ways: The "run" (and "run32" for
> the emulator harness) target wants a binary built with HOSTCC. The
> install target (which prior to your series does nothing) indeed wants
> building with CC. So maybe we want something like
> install: HOSTCC:=$(CC)
> plus suitable detection of whether the opposite set of objects are
> presently in the build area, requiring a full rebuild? (Of course this
> will work only as long as HOSTCC isn't used for any build time helper
> binaries. See "x86emul: test AMX insns" for when this starts not to be
> the case anymore for the emulator harness. So we'd need yet another
> variable to express this detail.)

Having slept on the problem overnight, I'm going to argue that HOSTCC is
conceptually wrong to use here in the first place.

In an arm64 environment, cross-compiling x86_64, this will explode
everywhere, and the fault is with using HOSTCC rather than CC.

HOSTCC is specifically for compiling utilities executed as part of the
build.  Tests, and particularly arch-specific ones like x86_emulate, are
not in this category.  Whether you happen to be able to run
test_x86_emulator in the build environment is a property of whether
you're cross-compiling.

For a non-cross-compiled builds, HOSTCC and CC are largely
interchangeable, and won't impact the ability to run the binary in the
build environment.




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.