[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] xen: rename wrong named pfn related variables
- To: Juergen Gross <jgross@xxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 16 Jun 2021 13:01:41 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P4Qd2KX4Ezz3bmQaG3UyE0GNrbB+QN0FC8EFB3mW1zc=; b=iUGlSOSLGP2akuSzhGQX05Cwp9me7MXFqcPIzI7umeYppExWf8icgT3DNY0cUujCRjvRk7WAuIEsA18j3EA+2746Cl9FxrWlSYF2OHXfYP/afE5Ip4zS/MYhn93qQqGMlwZGEqI4tfG4/a465g5vOuf26FyHuAeIQVJvP2PMtqnuf0KtiwDq45K3Rzs3kBEeolJ+B1SLRTjYgp+q7JCcUOCcWHi3fFbbHVlHhAxYSSjit3pgCubUahdaYs59g5Xcd9z2/XEqwvYrldBgonC6jsu/bIZcNrHJMAcsfsmzKI/mLR2wvDQJyQtJcNWDRvLTcjkmlfH4B7P+OAXlWTsq5A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=goLh89kPEN+DH5mu+Q1OEIsgNuLMusl000kPUUeFJujS7KxDWDju8GI/IUyVqgbZQupZKoL//ZFkZofc7HbruzVUntx6rKgCvtqL1nDaBfOzqNWWiysIGSqWl8Mohs181q0SVERiUxFZlxRCCfyKrMDI3esg0R07wKBPfJhryf7bZTWXcQ7HGASNDl7Lt3B/4mL4b+hsGqo6SC8pD/CihoOOjfTJjXDNbmDNGwOBAeIIyDfIxYHrl85FAGEKatcPSQLTlFYFLY1UmPwzTGHPdoRSlbEziCwZeyDc16UzRONC0wzCiuzrovTomNxeYC+CrUl/5PgNWjJlvug2JnQiVw==
- Authentication-results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=suse.com;
- Cc: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, x86@xxxxxxxxxx
- Delivery-date: Wed, 16 Jun 2021 11:01:51 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 16.06.2021 12:43, Juergen Gross wrote:
> On 16.06.21 11:56, Jan Beulich wrote:
>> On 16.06.2021 09:30, Juergen Gross wrote:
>>> --- a/arch/x86/xen/p2m.c
>>> +++ b/arch/x86/xen/p2m.c
>>> @@ -95,8 +95,8 @@ unsigned long *xen_p2m_addr __read_mostly;
>>> EXPORT_SYMBOL_GPL(xen_p2m_addr);
>>> unsigned long xen_p2m_size __read_mostly;
>>> EXPORT_SYMBOL_GPL(xen_p2m_size);
>>> -unsigned long xen_max_p2m_pfn __read_mostly;
>>> -EXPORT_SYMBOL_GPL(xen_max_p2m_pfn);
>>> +unsigned long xen_p2m_max_size __read_mostly;
>>> +EXPORT_SYMBOL_GPL(xen_p2m_max_size);
>>
>> Instead of renaming the exported variable (which will break consumers
>> anyway), how about dropping the apparently unneeded export at this
>> occasion?
>
> Why do you think it isn't needed? It is being referenced via the inline
> function __pfn_to_mfn() in arch/x86/include/asm/xen/page.h. And
> __pfn_to_mfn() is used via lots of other inline functions and macros.
Oh, sorry. Not working that much with the Linux sources anymore,
I didn't pay attention to include/ changes living ahead of *.c
ones, and inferred from the last file touched being *.c that no
headers were getting changed by the patch.
Jan
|
