[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/5] tests/resource: Rework Makefile
- To: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Tue, 15 Jun 2021 17:49:38 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pbLHhndlWfPbIjpZBwRZA39NCitsbsjUprrUh9jKPyI=; b=ld43lgm+mK8XCGxEyvfKJhE5zWg1D07+qddI4uj5StLHu3KHK10N6yr9yZ9Gqleoa2Jb5RwdpJ0168r+w92nGgzewJTX7xr6VLh8EzXMaawOKS5WMvkX54gV+gnrIURCcmanuERIp9OGnrYvogcBUiwHESj7qcg9JgK/V8CToyG4WsJqnRm2Iw4b9S+/C/E8GRjL1+xGCiZjlNFdVYNM95HTnvRScu10PklPW/T7BooR3Oun9IFDs0xJC3sEXgsquMri6r7dlc10ESNXjw7YTMdx5jHhLmtf2nSESAjoGGstUV7iI+DGSMAfcleBNZGUHt12ABORCTODGSI5jZooug==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cnNlTW1yCAPaR6MUy3JhrJDqkpwlWb1xd+I7XsEWj/iNahLB7O4ew/jtP9BKAmVgmhYX3kKYZsbWAyimAdv5MLew53Kslf3IzgAzYYU31fghhFevnF4Q8zJb2XPtFihNWxhyNEO0f73vyjvTDi7Zt7UlLk1OGOCq+UrCdAKXDy7rNiBKrz+EoXb5PGbrnXbHEuBcIeC+Q22mqMU7iPkUinit+LmgShzEe/pVa4WWdszcIeUr1FgKOK0GWEnqnhr/TqtbmLeE9aftc/wMHxowbMBCMRwQ05Z28seLoPau1qYpH8x+WXgpdpf3fDXt7OGo3W0hEsALdT4O8AFVAhGRYw==
- Authentication-results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
- Delivery-date: Tue, 15 Jun 2021 16:50:06 +0000
- Ironport-hdrordr: A9a23:zePY8q2jCcBrohKIOlPSoQqjBLYkLtp133Aq2lEZdPUCSL39qy nOppQmPHDP4wr5NEtLpTniAsi9qBHnmqKdurNhWItKNTOO0FdASrsO0WKI+VPd8kPFmtK0es 1bAs9D4HGbNykZsS5aijPIcOod/A==
- Ironport-sdr: y/+kGFqlzsQoIarcprcwhK6zJ13kFKVAxRs3gVTavZZ1bGdIMgvLe4csR4ol0pZLVyrse7uycc gICOyQLl+jU14bEv4yGObea9PGpDyVZMXwRfkg2jc1Ye0sk65QFYSfGo5MQkmnbWdHGK7Tsi6+ DSpWQoBm+UiuGb7TGTxKURyknX/nN1tSZcl3MN5devvfA62EGs2PIfGdyq3HicQdZy09wouqqE HvgNTTH3KZESWbgz3Fhyi3d3XrccrsgCInRQeWPibMIVPjX6vzm4A2wUHrrKJB814dVbKPmcTL n3A=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 15/06/2021 17:19, Andrew Cooper wrote:
> In particular, fill in the install/uninstall rules so this test can be
> packaged to be automated sensibly.
>
> Make all object files depend on the Makefile, and us $(TARGET) when
> appropriate.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> ---
> CC: Ian Jackson <iwj@xxxxxxxxxxxxxx>
> CC: Wei Liu <wl@xxxxxxx>
> CC: Jan Beulich <JBeulich@xxxxxxxx>
> CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> CC: Juergen Gross <jgross@xxxxxxxx>
> ---
> tools/tests/resource/Makefile | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/tools/tests/resource/Makefile b/tools/tests/resource/Makefile
> index da5e2a4f9b..b22eb6fc21 100644
> --- a/tools/tests/resource/Makefile
> +++ b/tools/tests/resource/Makefile
> @@ -16,9 +16,12 @@ distclean: clean
>
> .PHONY: install
> install: all
> + $(INSTALL_DIR) $(DESTDIR)$(LIBEXEC_BIN)
> + $(INSTALL_PROG) $(TARGET) $(DESTDIR)$(LIBEXEC_BIN)
>
> .PHONY: uninstall
> uninstall:
> + $(RM) -f -- $(DESTDIR)$(LIBEXEC_BIN)/$(TARGET)
I've finally figured out where $(RM) comes from. Its a GNU Make
default, and has ` -f` included.
I've altered this and later patches in the series to take this into account.
~Andrew
|
