[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/5] x86/platform: Improve MSR permission handling for XENPF_resource_op
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 14 Jun 2021 14:45:39 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tNv3bKAdlk18Lf3VKXW+E+FXFOtvnHMTt67yV+SM2Qo=; b=UxJFN7p02v+s10AyJb/tv7N5Q70rFRtw+/+axPSeVqpq0ll0b8J6beHHBkaDu9hffsIjmVYyi3CcEgTqOB8SNHHtXkUlwV9KYnkz+NUuTie6iJOSuI/EYTb1i+JNV5DJtYyOtf5XMoO0OY/NLp1ncoxdwknUDZDsT3fzj55fbUgzGqG/I9N8g6rxG5rh8hK/NdRuWveFIUR/7g+MhUPUAwh8OvcEgKBkkRg/GbFS4S0AeJZQu9U3NeGrLWHHPy5Ef3Xpw+d84gi9lqroSgI9foQzVLFbwpgg4ouFccKnxXjN8Vs0LsV+l/X7JvDkvJHGcaPqNofIGEwhi7E+fzwAQw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ngZF+J/4kdqQFAduV12XtUpQl1x3ong7PX4IoNVy/PXa4mDhm8fPSBNwDEpA6PgCY3MunJWUoEAYKVyFfNB47ZgZDSg5C8xAO0HoKPMqJ0jpl3VuH0FIu0nd5WZ6L7jWN2qSZP0ucMCJq0kiiZt1i+5sw+25uVme11BBwX0e6KALn7yLzL6xYO0Qc0FvzftADU4pppL6B1TDu2FDK6y+8iUFQq4tzv/pl6AYyaHIuU28MRAWHoD1j5vKWyTsQlDuJSKfBpILiri6EgmMOvDDkhxf31t18a//Pe1XIPE9ZA4zmnec+Q/QaXn1zxSB/24Nz/rNe+uMp949Fmmx2u1mtg==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
- Cc: Igor Druzhinin <igor.druzhinin@xxxxxxxxxx>, Edwin Torok <edvin.torok@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 14 Jun 2021 12:45:54 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 11.06.2021 18:36, Andrew Cooper wrote:
> The logic to disallow writes to the TSC is out-of-place, and should be in
> check_resource_access() rather than in resource_access().
>
> Split the existing allow_access_msr() into two - msr_{read,write}_allowed() -
> and move all permissions checks here.
>
> Furthermore, guard access to MSR_IA32_CMT_{EVTSEL,CTR} to prohibit their use
> on hardware which is lacking the QoS Monitoring feature. Introduce
> cpu_has_pqe to help with the logic.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
|
