[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Arm32: avoid .rodata to be marked as executable

  • To: Julien Grall <julien@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Mon, 14 Jun 2021 12:40:47 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U6Y9TEnLy4A3egQcw338VygtEogIv1SMQnGzmu3Kcoo=; b=fcAPlxra443yKwaG1R+Ya6r5MEdXQE0K8SnB7sBMfNJm0NvSNZv1zBs1QA+z3FI8SHVJNBYs6HnIuisDkRfOB1+VMiX/qT/yfHfKwhcZOzkeRPkkBZbth0x7MJQlg/cw9Mhxzg9T66MV/5/vO88FoFX6lo7CyhxNZtbEQmPougJ2CQwarIoMwg/S99/vI0LHXw6y5apBhlSBh9IOA8P0WHBL6LEeeNS7Yv8cm/48RDhu+mMY9EwIoeNv9B9XBOSJgPzqADwBChFLZH89MYiwtnO++wwbVUQ3PNlwhaApdN0TMDx7UdUAlIpUD2VniqRWqj7zIdpvxEFOZ5loax8hyw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SDjvJDL0W+6IeDDNFUj+nRhV680eGJCGMURSZvAdrmLMpZXnBl4Jyr4/Ia3n0UcJePK2ikkYKt/0fO9jhj9bLpPXMLbe2M/bBQ23xK30IKLnI/lGqAAfzSLwSbL0VDAeNF4eYzTsZlruRIvrZ7ne8p2fi5uolGr0xX7gTnow+34BXiCAZv7erol7A+kik9qzJvUhSmsSa+ogKhiflzv1x9G+QFXAC8hNjuUFQgfb3cm98rsLHV6jGT9M2H6cTd3JFEFMl494Fcd9N5MgnGqEbdfej4h4eo9I95DuGBfv8zvF6c2FbT04THavzeqYoJzM7hpxy4rNnrbqOoEuKCGoAg==
  • Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
  • Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Mon, 14 Jun 2021 10:41:03 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 14.06.2021 11:57, Julien Grall wrote:
> On 11/06/2021 11:19, Jan Beulich wrote:
>> This confuses disassemblers, at the very least. When this data still
>> lived in .init.*, this probably didn't matter much, albeit the
>> "#execinstr" would have been suspicious to me already then. But the
>> latest with their movement to .rodata these attributes should have been
>> dropped.
> I don't quite understand why this wasn't really a problem for .init.data 
> but it is a problem for .rodata. Can you expand your thought?

I've said "probably" for a reason, and my thinking here goes along
the lines of what I've said on the other patch regarding .init.*:
There's perhaps not overly much reason to be picky about the
attributes of .init.*, and at least on x86 there is also a case
(the EFI binary) where we fold all .init.* into just .init anyway.

The alternative to the present description that I see would be to
go with just the 1st sentence. But I would be afraid in such a
case that you would come back and tell me this is too little of a

>> Fixes: 9cbe093b7b84 ("xen/arm: link: Link proc_info_list in .rodata instead 
>> of .init.data")
> I don't view this commit as the buggy one. I would prefer if there is no 
> Fixes tag. But if you want one, then it should be the patch that 
> introduced #execinstr.

I've dropped the tag.




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.