[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/arm32: SPSR_hyp/SPSR
- To: Julien Grall <julien@xxxxxxx>
- From: "Edgar E. Iglesias" <edgar.iglesias@xxxxxxxxxx>
- Date: Wed, 9 Jun 2021 21:42:09 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=xen.org smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TT2wVoqIIhbCEe6+6/5VTaC1yHQtIarCslgk7GCNoMw=; b=ayWOQ3eZifvc4Id6+dEs/6GC7HjV69jgvxOZTsfyX2lHwsXYpx2rchyxgkMnT8cnprP91dAx4ReNE3o+SJrpVQO4ui7dLYIu9t6awnVIhpaK1qNUJ8ntjHRYm/gDE7KMAHD5cLGJLyTTSG7JVbGfEC7pfk4sMZRqsOtNPW6C8aVWYj6laybGJf885XPVvf/DLQtgyHy2zjurpjHNTxgpPmdhsM3hgqtxU7GPkTJf3MWq0q+ePYYnxLlg7c+dbx4BN//zGJ1iX91Aa1fNqVJtksfR/oZtd2IDE1tNNOxEIIPaKLMiIb6avUXnlJurspv+bO/sd4bYhpboyWGMi5IPCw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZrfnfA4j+5aeA6ipStugEk+R0/FsH0PZsluFpLtZelBEl6ow6eWEiYZDI1k/qrNty/ulg7182vvgCbQgRZPz4t0jHTRKIJrPzEwdTzjhXxzX5ZWCTJdhzyTu+ZGU1fyVnloJYmfEzU6AClR0RTrTwiXNnWWELFwPKo7F/q+fdmBDp8oR2ggQ1jaXDzlVYW4StStco0b0lvbRIXG71EwwzI9uA/fonnH1ff1aUGL/XTwok03voZppaA7UXo/m6zN5uAklkXRfb30VDY7lUeMOSP8gPnV9v0P+fVfuNipEuYKJWprL1sr0mnNNr5aquuxo5+WCNQCkfjs4F8qJdkxdrw==
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, <Volodymyr_Babchuk@xxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>, <Bertrand.Marquis@xxxxxxx>, <Michal.Orzel@xxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>
- Delivery-date: Wed, 09 Jun 2021 19:42:25 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed, Jun 09, 2021 at 06:53:02PM +0100, Julien Grall wrote:
> Hi Stefano,
>
> On 09/06/2021 18:43, Stefano Stabellini wrote:
> > SPSR_hyp is not meant to be accessed from Hyp mode (EL2); accesses
> > trigger UNPREDICTABLE behaviour. Xen should read/write SPSR instead.
>
> Please provide a reference to the spec. This helps reviewer and/or future
> developper to figure out quickly where this comes from.
>
> >
> > This fixes booting Xen/arm32 on QEMU.
> >
> > Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxx>
>
> With the reference added:
>
> Reviewed-by: Julien Grall <jgrall@xxxxxxxxxx>
Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xxxxxxxxxx>
Tested-by: Edgar E. Iglesias <edgar.iglesias@xxxxxxxxxx>
Cheers,
Edgar
|
