[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86: mark hypercall argument regs clobbering for intended fall-through
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Wed, 9 Jun 2021 13:49:50 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SeKYIAeEx046XORKXKP0uvH2+V2+OhK5AJ0CFkDfCbM=; b=lTBuUccAF6KZ1Tggz4Rf1HlaPZobfDY9Y0bY6QnlnTBmHDLDE02RE6IaLtuZ1ERCPNdU+Esol1BRiKGSkb2GnTvZH7KD2Bd7Wcte1UGVGBwXbML10+t/0F3zP2SpxMs2c6ugnSeGOjtAs2ZGaQF2N+lAtyChwLxIfHOXwxS5VfDd6kOKV5zRFu4NC4kC5FnsCAIIfuyNp6+MbV744dRmzfxMGo00W/riHm8HP9dOZRfPb8dTD4sxQRy9EzI63Q5zn1eaIeGSQnW0jpshvBPIyWY+pRF59LOMJ509b9MRM8B455zaSk6Wt3UdNAijEZR4K0Hw91g0LsO/Tf5pAc7nlg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fXhmOqTYndHQHKc+SBaHD6GKsWFM+UpFVgLV6hmknrDkU5lKEytm26T90CUe3n7W5jsjMTuy7YsP0YWrxuJUpAUOb3q99c96p9jmR4kEmWjy+b0TsfHz34cRWGFtka9IBwFWaN7mQgZT3ge4mHaB5jjC6zRjSv600v75CI3Jxrp7y9pzTRekAizJF5DbL9fPh1UUGbLx+ez6KxHNvmGf83UdYwnbSRhD9BjxnKmo/xCwbV6a9JMQYIuBZgkSckkd67ZxO8grNEu1wGiVLPAMxt5lXMqMzJVDoh+mDx4Yj2qq1c/iY6hq+Fq1ArxUTr30stmj0LVsyfyOqAKWACSo/w==
- Authentication-results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Wed, 09 Jun 2021 12:50:09 +0000
- Ironport-hdrordr: A9a23:wIk6+qFqngcUvD2YpLqFDJHXdLJyesId70hD6qkvc3Jom52j+P xGws526faVslYssHFJo6HlBEDyewKjyXcT2/hvAV7CZnibhILMFuBfBOTZskbd8kHFh4hgPO JbAtVD4b7LfCpHZKTBkXGF+r8bqbHtms3Y5pa9vgNQpENRGsZdBm9Ce3Wm+yZNNXB77PQCZf +hD4Z81kCdkSN9VLXKOpBJZZmMm/T70LbdJTIWDR8u7weDyRuu9b7BChCdmjMTSSlGz7sO+X XM11WR3NTij9iLjjvnk0PD5ZVfn9XsjvNFGcy3k8AQbhHhkByhaohNU6CL+Bo1vOaswlA3l8 SkmWZgA+1Dr1fqOk2lqxrk3AftlBw07WX59FOeiXz/5eTkWTMTEaN69MdkWyqcz3BlkMB30a pN0W7cnYFQFwn8kCP04MWNfw12l3CzvWEpnYco/j5iuLMlGfhsRLEkjQVo+M9qJlOi1GlnKp gsMCjk3ocTTbvABEqp5lWGqbeXLwEO9hTveDlOhiXa6UkMoJjVp3FojPD3pU1wgq7VfaM0rd gsAp4Y442mcfVmJJ6VJN1xDfdfWVa9Di4lDgqpUB/a/fY8SgPwQtjMke8I2N0=
- Ironport-sdr: 0XHOScb0XYmIJHriv/JRoH32Sbi7sdt+IaCoAOMIZhnDzWrn0anKiRdad7fPMZTMcz1dr0n79T iagHxniTxBJcZ0BSipth8QRFbP3XiYOV38iwqChf9WvHvzsglpLaqKwxFce8zn6cS1BqoEoA95 CUUpyyUkdvDf5T3E6C97LQw+nmOMjITy2UTeqnqqgW2X0YODSP5BU1to/lpYtINdw0xlj9LMV8 6QmgVK1/CdbKIKcSZ1MGvkTd4FTs+hrFlYMxcpxZ4TkNBF9m3jSxw6Np+TZ5iRcSJ/qKACKt4h 6UY=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 09/06/2021 11:34, Jan Beulich wrote:
> The CIDs below are all for the PV side of things, but also take care of
> the HVM side.
>
> Coverity-ID: 1485896, 1485901, 1485906, 1485910, 1485911,
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> ---
> Let's see whether Coverity actually understands the (relatively) new
> pseudo-keyword.
This is exceedingly disappointing. Coverity used to have the only
sensible rule for not causing spurious fallthrough warnings, but this
has apparently regressed.
Coverity works on the AST, so ought to be after GCC has interpreted
__attribute__((__fallthrough__)) if applicable.
However, I doubt it will work in the fallback case, because #define
fallthrough looks dubious. To trigger the older logic, the /*
fallthrough */ comment needs to be the final thing before the next case
label, and it isn't with the added semicolon.
Given that this pseudo-keyword is restricted to the SMMU driver for now,
we don't actually know if Coverity likes it or not.
~Andrew
|
