Xen project Mailing List

Re: [PATCH v4 0/5] Fix redefinition errors for toolstack libs

From: Christian Lindig <christian.lindig@xxxxxxxxxx>

Date: Tue, 8 Jun 2021 13:34:16 +0000

Accept-language: en-GB, en-US

Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none

Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xE6+oRxbKNJo7ZPKq1oHeK7zWBfy6gXm7RqYweJ1C1k=; b=YQt4gQq2wtA636894V652QEPnXX6yyLILFUMGsQRwRWMTJg89EQjmLacY1OTadfppKQls0yU8ZQLEiSe0IbNc54zD2fugsB5xp3+OmeQS7yUwtQ9xE//BF3D3z7mbFxVfom12S+aKZjlBHZALd75/F+Z/QN70DASPT8CflQjnbLRJsPIno8DgBRyv8SKlDCMBM09oVvG9qJwLBSFWH6pG/tg5b5d7vKdPIhWsSgUYTPIN4gsDTbHCS8vq2BoKjIjp1N033VQjmP1xT833bAdJDTQBm0AdJ0FtJkbS+Ja+rOfEnFDS9ueNixXzAHoi/7XQZ0hi6Q/J8Z9Ie6xz+kElA==

Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mrtKYwYT5LUJtO/CzcOdxAeIBMtRPjczFPagN/XOrFH/bor6mQX2pCjPh6K+4Aepeip7eYU+S/JeDyWREr+pllAi3eGO6D6NW6FJ4MD/nz3jmFabqrNfpfk3jkh2iZ40N1XJ8dTitvQfMNR6TFx4FpAbd+dNQDmStW/JhHqKMnGsJQ6CrYJLUN9FQz/hJlOeRvKEXT2kIIVwx7fzvdOojdG9DizjdRvu+Z/rHOXQ/ic1oYQ5aYDTdzc+A27pQy3sW3sZkBWCDxmIbmei+wuggUWllODnozaDIDUU55qu8BnMvTSAA1a3fa7J92awXF/ABPCeUEkecNpEBvof5VhbLg==

Authentication-results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com

Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>

Delivery-date: Tue, 08 Jun 2021 13:34:38 +0000

Ironport-hdrordr: A9a23:BWkdZKt6L+04Bi6Xy8Txx1cm7skDjNV00zEX/kB9WHVpm6yj+v xGUs566faUskd0ZJhEo7q90ca7Lk80maQa3WBzB8bGYOCFghrKEGgK1+KLrwEIcxeUygc379 YDT0ERMrzN5VgRt7eG3OG7eexQvOVuJsqT9JjjJ3QGd3AVV0l5hT0JbTpyiidNNXJ77ZxSLu v72uN34wCOVF4wdcqBCnwMT4H41qf2fMKPW29+O/Y/gjP+9Q+V1A==

Ironport-sdr: OFoZAir28eUXPJ7I0jbCBuuxNsu5GCF1IOvOINYp2YpWUEL6JRO6JVgsaOTL+hl/fnn35C34FR XP5NxnN5ruGMPC/3jU61yM3UtG95BO98gxMVpftgtVnx3mvDB1kKWUyHl616K7hqxTXMbvCJiq b+Y2Jr1fE5BMrU5oLgQF7NZvgegQB3qXyP87SqQEw1hDRHQs3ylxrAigQI6dmY8I7LVTWxytNs kp9gVZrUjP6KMb/ooYBYRGhm5b+S+upcL4MV4i58eJCsYEl5QWtUmRQEp++2ejTVQHV3/jesc3 KbM=

List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Thread-index: AQHXXGLhcoHJqYzC7UuAEWyaYS0iZ6sKHS4A

Thread-topic: [PATCH v4 0/5] Fix redefinition errors for toolstack libs

On 8 Jun 2021, at 13:35, Costin Lupu <costin.lupu@xxxxxxxxx> wrote:

For replication I used gcc 10.3 on an Alpine system. In order to replicate the
redefinition error for PAGE_SIZE one should install the 'fortify-headers'
package which will change the chain of included headers by indirectly including
/usr/include/limits.h where PAGE_SIZE and PATH_MAX are defined.
[..]
tools/ocaml/libs/xc/xenctrl_stubs.c | 10 +++----
.../ocaml/libs/xentoollog/xentoollog_stubs.c | 4 +++
tools/ocaml/libs/xl/xenlight_stubs.c | 4 +++

Acked-by: Christian Lindig <christian.lindig@xxxxxxxxxx>