Re: [PATCH v20210601 08/38] tools: show migration transfer rate in send_dirty_pages

[Juergen Gross <jgross@xxxxxxxx>]

On 08.06.21 10:58, Olaf Hering wrote:
> Am Wed, 2 Jun 2021 09:10:44 +0200
> schrieb Juergen Gross <jgross@xxxxxxxx>:
>
> > MiB_sec = ((ctx->save.pages_sent * PAGE_SIZE * 1000) / ms) /
> >             (1024U * 1024U);
> I'm not sure: how does this improve the patch?
The scattered calculation makes it much harder to verify it (at least
for me).

And initializing a variable named "MiB_sec" with a value being clearly
bytes doesn't help.


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature