[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/cpuid: Drop special_features[]
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 8 Jun 2021 08:18:56 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TkjRvjkQYKteAAZxSNLFcpc0YVSD/cAeIqlCB9bbeDo=; b=BjS8pzKJK+/Y8wRqPEoPCoS4I3XOfGmIvYbaYoRoppVe5ej7sAt3eGq0rBG2uq25Yb49z/PLdNv7vBQSfK0jh19wBRf2mX0buPhkxtp/zVtDuKf/WEnl6EoPBvze+i/C0vwCqBzZRUGCB0XU9oHf8YeWuXMy87XZT79hSzHFGqG8RdeI6zaANCVBm7Pr5VSrYAJwZoEoikmaeAK7P09fpE8RPJcx2WglfZjLZdqFX+pXLyILOAoYwyccKQ1oqAiUrZ3OlIQEB+quMjGK28sVRnF+XVhs3tNjywRYHFdA3nPxTXXfwoDsl/H2rcV5kqMOFI+Ufdyvl+RAw3n1kjsIsQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ut5FNj2o/n8yVjUl6S7k2XLELUV6nTGlhnialy9F6w3ntmCYQWUWd7536FQaoSzZo1RWoYNa4KcvSPWVw38W7dxotNnKKBB+N9R7sqzYJgrPpFawHmsrEusNafsyBO96NvHxZ96kIpgTnrINw01sxONMxIzIgrhBokLZYHPR1teLODPAyYlXNnXV9yCM1wVSPauPmP8peS5WmYvCd7yUcGZe326wwp7G/uObV3/FIv7GVQoXJ9aO4JFY58Vr68vbPbtSUDwqfdHRr9o5nif6A5jO5laLHqneniiCdhAW+FtF4QMifyr0PqoT5Ao0HAy6O8XXHSG6vwJRH9yEd3d2Fw==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 08 Jun 2021 06:19:15 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 07.06.2021 14:41, Andrew Cooper wrote:
> While the ! annotation is useful to indicate that something special is
> happening, an array of bits is not. Drop it, to prevent mistakes.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> ---
> CC: Jan Beulich <JBeulich@xxxxxxxx>
> CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> CC: Wei Liu <wl@xxxxxxx>
> ---
> xen/arch/x86/cpuid.c | 2 --
> xen/include/asm-x86/cpuid.h | 1 -
> xen/tools/gen-cpuid.py | 3 ---
> 3 files changed, 6 deletions(-)
As osstest points out this didn't go quite far enough, or too far:
Either XC_FEATUREMASK_SPECIAL also needs dropping (including its uses
in libxenguest and xen-cpuid) or, considering exposing this
information via xen-cpuid isn't entirely without purpose, the script
part of the original change needs undoing or making conditional e.g.
upon __XEN__.
Jan
|
