[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/cpuid: Fix HLE and RTM handling (again)
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 7 Jun 2021 14:52:44 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t16o32gG1VsGoX86uvlVT72Q3N6GoyS88sA+DaEkvNw=; b=Rv1wGOGDJy9k9bJvIq+ZH0+MUx7E6Uy1CyAvYhstRl0LB6oLCQUmwSJ0D7jGsRiYOsy+vnrbTmDnqTT6pYfa+EjPlu9evmNjueyibx6BlyCl0lWONTnkto+QH8EKN2YHCecZrq83soVLt87kePTVlbdq2hW7Ke4ERLdOII5uqH4Ux5hIprmqB2FNWCeOBm2PslV1RQDmQq3S4GaBfURYLrs5o0SibcxEkHa1gnGxpAqufKUUD7XyroC+8609FB8QyNeozk2FjuB4t17+NAWMvoJXk+vHRdvLTl7cGkiYqM9rkIEskZRoAjbP8D++vh1b8Xa4aXiMZkD5pAoj4NIf3Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DDuYixP7TfoL2jm0vDQfDURt0xP+X3p7Owjt3+1Ltzo0044Fc3RWDcE8LU47v2cCTC21aqndAs6zzMpokxAMLL3j44LqxKRP0r0EsbYYXCIcXXowY/9Rl6wS8UPJoqFZGBVJc+W4lY9QJaGL2gxaAQe7HkTnio/PFcDctsW2aUKLDa4Tk0vnkmnkdDixiK1U0y+fnpo3Yv6zzTB3KTI5xI+p7wlJho65EjetbTXbE62ZTwsr7sQsq2XB9Fk0PbutUjHXQmLpX/CcgnNYylhIzXKClHbB1Cr+T1J7fSkTzVPv9EoqJXySElLl9vr4b5iNpFYMy5dNhs0wd5x+1SLrNw==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 07 Jun 2021 12:52:55 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 07.06.2021 14:41, Andrew Cooper wrote:
> For reasons which are my fault, but I don't recall why, the
> FDP_EXCP_ONLY/NO_FPU_SEL adjustment uses the whole special_features[] array,
> not the two relevant bits.
>
> HLE and RTM were recently added to the list of special features, causing them
> to be always set in guest view, irrespective of the toolstacks choice on the
> matter.
>
> Rewrite the logic to refer to the features specifically, rather than relying
> on the contents of the special_features[] array.
>
> Fixes: 8fe24090d9 ("x86/cpuid: Rework HLE and RTM handling")
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Reported-by: Edwin Török <edvin.torok@xxxxxxxxxx>
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
|
