[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tools/xenstored: Remove unused parameter in check_domains()


  • To: Julien Grall <julien@xxxxxxx>
  • From: Luca Fancellu <luca.fancellu@xxxxxxx>
  • Date: Tue, 18 May 2021 17:12:04 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eiBLi0AFnGNZcNcezd06ehlbAK8xI0EM1EKgwai0JwI=; b=aSE24dozesi7+im1ur1Oh94GYw4WdsarPcUgdPtr4w6atEngOyt3mbuoyvpUViRseCP0VscZRNTjva5SGxKxE7YChInhKKSdZrRlvBCJHryQ5+k2VoEpcaIOo2WSbtiNFAudgxVEOvnJ70zvbT3Xk6eVjgiAmfKI3Sk4GjYToepIIFHTvUoeTAB9JopoDoUcf4jOmceF9QNMc6Un/pZn+IPkLNr17JrO6WPk2XnUCa2Pxu86KmSP+x8ChcUIXmUpPWhYbVZ5a97t4CmWuYC1gDmKif/+nRl3t/aDjvp/OzuIJN9SH1AmnyGpqDlbszd58rYgZXkyeIUAxR+0lJwOIA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m2pC8JJY3aYOqQwRCNW6Sm1Y450hTsrI+OHmcpbjKDoF/NBGF7JwUOnwkfcKQ8jO8uqzdb1XnDRjqaFjlIfWcPyaKAgr51mjZYRAuu799wQd51asGjrt9vnDehlWKif6C5pYxAOBxnm59aDgTHSwHzEfiW/339AcYFocy2Uk2LxCqKhd1Z/+XExYMGTL7+9bBRJVU2BsGZiSaY7ArdUyunCvtWrgT1o5OtfKB4552wefSjwSjNy/NczaVHySR3gXr6I/xjrEifLNGb4X/D7ED6HRnYoIu8BUP5u/Dl44n+p2nM0PNoKzhPsaM7GS4qNyYo2qL5x3V0C6l9luKCBh3Q==
  • Authentication-results-original: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, raphning@xxxxxxxxxxxx, Julien Grall <jgrall@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
  • Delivery-date: Tue, 18 May 2021 16:12:53 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=arm.com;


> On 18 May 2021, at 16:21, Julien Grall <julien@xxxxxxx> wrote:
> 
> From: Julien Grall <jgrall@xxxxxxxxxx>
> 
> The parameter of check_domains() is not used within the function. In fact,
> this was a left over of the original implementation as the version merged
> doesn't need to know whether we are restoring.
> 
> So remove it.
> 
> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
> ---
> tools/xenstore/xenstored_control.c | 2 +-
> tools/xenstore/xenstored_domain.c  | 4 ++--
> tools/xenstore/xenstored_domain.h  | 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/tools/xenstore/xenstored_control.c 
> b/tools/xenstore/xenstored_control.c
> index 8e470f2b2056..07458d7b48d0 100644
> --- a/tools/xenstore/xenstored_control.c
> +++ b/tools/xenstore/xenstored_control.c
> @@ -589,7 +589,7 @@ void lu_read_state(void)
>        * have died while we were live-updating. So check all the domains are
>        * still alive.
>        */
> -     check_domains(true);
> +     check_domains();
> }
> 
> static const char *lu_activate_binary(const void *ctx)
> diff --git a/tools/xenstore/xenstored_domain.c 
> b/tools/xenstore/xenstored_domain.c
> index 3d4d0649a243..0e4bae9a9dd6 100644
> --- a/tools/xenstore/xenstored_domain.c
> +++ b/tools/xenstore/xenstored_domain.c
> @@ -220,7 +220,7 @@ static bool get_domain_info(unsigned int domid, 
> xc_dominfo_t *dominfo)
>              dominfo->domid == domid;
> }
> 
> -void check_domains(bool restore)
> +void check_domains(void)
> {
>       xc_dominfo_t dominfo;
>       struct domain *domain;
> @@ -277,7 +277,7 @@ void handle_event(void)
>               barf_perror("Failed to read from event fd");
> 
>       if (port == virq_port)
> -             check_domains(false);
> +             check_domains();
> 
>       if (xenevtchn_unmask(xce_handle, port) == -1)
>               barf_perror("Failed to write to event fd");
> diff --git a/tools/xenstore/xenstored_domain.h 
> b/tools/xenstore/xenstored_domain.h
> index dc9759171317..cc5147d7e747 100644
> --- a/tools/xenstore/xenstored_domain.h
> +++ b/tools/xenstore/xenstored_domain.h
> @@ -21,7 +21,7 @@
> 
> void handle_event(void);
> 
> -void check_domains(bool restore);
> +void check_domains(void);
> 
> /* domid, mfn, eventchn, path */
> int do_introduce(struct connection *conn, struct buffered_data *in);
> -- 
> 2.17.1
> 
> 

Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>

Cheers,
Luca


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.