[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH 06/10] xen: replace order with nr_pfns in assign_pages for better compatibility
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Penny Zheng <Penny.Zheng@xxxxxxx>
- Date: Tue, 18 May 2021 09:11:24 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5Q7KXzE/8MKF9VUsFuMvHcTZu5f1VfqfVr7nJoEsK1A=; b=UxS0k/JazVllUCznwx7NYb9y5sE/h5LBxo2maDQydyBsTGcHbh79X/GTlGZt42sm/JqDd7Gyj220sX1uQdQXtgQRj32wt2C2hIO0NGiKaQezSnR50/lGgIBRqtccjs92U/OSgcqLF014TyRMnFpzHmSag1BmXucqid+5qqLmZLZthgUBXeF/mxTJbZB/zlKjZDH2pfxqnnEXOx6S0qxrJC92VKMta+ulwQWnhOe+AHN5jAFPcvJrU+W/IK2IbZJ2PU1n8jcmWqu/X39HqbU5Sh20YXCUXmw5IDp9cuGb5NVe/C0osZzwndXvhqLznyB/K8gzB854mOTcLfyFykoECQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RkqhRsdP5tX0YzNSqoGQvwoktyoxmuGgUZjHvA3nJWz0Aqju7rViAVmF7zEsuItLb/IGNxn5Wu+b8Amn/VEod/TsQnNHMOAX3sQuCCY8Rl7DI05DDFz5tNTJGCGc2vKp3AWfEw4MOpEk0SA5EcemFgHH6nl4E1xvyzpwvFHwpc+HLhomUX2LGZFNr54bogyQ0w5sgqKFz8vdgUyN51sHGxKFDbl4Kkpe7NIK7MUY2SWWEtLSlEOQ61ypg8iQoA435fJo/JNfeL7FoJm49wSjae3/MjT7C5bDQSt7powYFRem8wJskNjWDImA0NAdpIohmhU7KcWXYaLM710/eaozFQ==
- Authentication-results-original: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
- Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, nd <nd@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, "julien@xxxxxxx" <julien@xxxxxxx>
- Delivery-date: Tue, 18 May 2021 09:11:43 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
- Thread-index: AQHXS6W5eIGNu7DPG0i7DMYwhf4hF6ro11yAgAAZR+A=
- Thread-topic: [PATCH 06/10] xen: replace order with nr_pfns in assign_pages for better compatibility
Hi Jan
> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: Tuesday, May 18, 2021 3:28 PM
> To: Penny Zheng <Penny.Zheng@xxxxxxx>
> Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>; Wei Chen
> <Wei.Chen@xxxxxxx>; nd <nd@xxxxxxx>; xen-devel@xxxxxxxxxxxxxxxxxxxx;
> sstabellini@xxxxxxxxxx; julien@xxxxxxx
> Subject: Re: [PATCH 06/10] xen: replace order with nr_pfns in assign_pages
> for better compatibility
>
> On 18.05.2021 07:21, Penny Zheng wrote:
> > Function parameter order in assign_pages is always used as 1ul <<
> > order, referring to 2@order pages.
> >
> > Now, for better compatibility with new static memory, order shall be
> > replaced with nr_pfns pointing to page count with no constraint, like
> > 250MB.
>
> While I'm not entirely opposed, I'm also not convinced. The new user could
> as well break up the range into suitable power-of-2 chunks. In no case do I
> view the wording "compatibility" here as appropriate. There's no
> incompatibility at present.
>
Yes, maybe the incompatibility is not the good choice here.
Sure, the new user definitely could choose the workaround to break up the
range, while
it may cost extra time.
And while considering MPU system, memory range size is often not in the
power-of-2.
> Jan
Thanks
Penny
|
