[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1] tools: fix incorrect suggestions for XENCONSOLED_TRACE on FreeBSD
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Fri, 7 May 2021 09:25:38 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xe2TIIEZvd1s1LX5EMJRuHRL8wZSW/ZcuYuYkQ090g0=; b=Obw1tKRoOzu0Mitvx1o/efGIAyBa1MCaAk6JLUGX9YI7hViTqqfLXuYOWo281C6MCj8gMhi+u0SYNG9RMGYKeVQzRzRZFSVGF2+rBQWkw7liG+b0PULZCYDQ4h8rxC0pp/jejm/SJnDu+A+WwY5GDry+bxpUlkBTMwT8Rsn8BjicIzrxcQG/uq+/EInLpwZkPYsCyVq7z2hzJUO7M4rAfeYWe/MjSDItRDwDG4nNiNpM3QTibmGg9+BHRLCuV0wj4gFc43yFBdaoDSnspzv9chmhmpL63V0IZiXRWLGq5jhTPckm/Xnwo5Ys9NI4BrOljc8Ovbwj0noT/j4Y2XT21A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BBnxOXyJnH24Q9FuGNSZe+Nhy9vmXV4vfYW2YlBCOVYS7sbByhI70uawTAGQu6OR9lWk2/giesup6sy/WX4BxnasbDJTrhXnMH9lF0MJ7ANXAAKVESpUxsXXribj+p3rrB0Je6cotE/rAu919LGamvxZ/j5KJYX5oS9ySmul390+3GU6yeN+WHfcmrsAE1VBzHCfrDRghjbbvoZKQ4CCByMJoghOvSjFTlyBgKcW1yGYPlSLG+gSOXwlhMta2tXAW1eEXJg/KuXx4QxJGrLhHplmLKAM/iqr20wkzpnKO3JavG/o69E96DNgE0BRa1PpGpOrNA4VmXmGe0O+l55K6g==
- Authentication-results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Olaf Hering <olaf@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Fri, 07 May 2021 07:26:07 +0000
- Ironport-hdrordr: A9a23:Bi4RUKEgevrzt9kbpLqEEseALOsnbusQ8zAXPiBKJCC9vPb5qy nOpoV+6faQslwssR4b9uxoVJPvfZq+z+8R3WByB8bAYOCOggLBQL2KhbGI/9SKIVydygcy78 Zdm6gVMqyMMbB55/yKnDVRxbwbsaa6GKPDv5ah8590JzsaDJ2Jd21Ce32m+ksdfnghObMJUK Cyy+BgvDSadXEefq2AdwM4t7iqnayzqHr+CyR2fyIa1A==
- Ironport-sdr: U5HyNIUuFsaGWUcHqp5gQR8vXgdXuceHg24avFJeFMiPKADBJYuB9rGe1oQuYquXI/wHM2Fo8P nFAXVGqhAejJZ+tQgSiRax5yiKn+oZ4rz4aePpOgnZc4cDlY6OyDbhzaEmOA6xxNHWLPk72KVY jeByZ9wDkg3hwfnDIsfhTOYRUNMh5nH6f+j3HLs+zqzCPqeWao+tZaXvPlfoZRs5Aedde8CnvQ viaWhYwV7ptydyNacdJgwgEOKmGBbXOwloDmIecChrJStE2WC7+/Km/lT/yy83EgahIdN8kfpn tOA=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, May 04, 2021 at 06:47:12PM +0100, Andrew Cooper wrote:
> On 04/05/2021 14:50, Olaf Hering wrote:
> > --log does not take a file, it specifies what is supposed to be logged.
> >
> > Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
>
> Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>. That said, ...
>
> > ---
> > tools/hotplug/FreeBSD/rc.d/xencommons.in | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/hotplug/FreeBSD/rc.d/xencommons.in
> > b/tools/hotplug/FreeBSD/rc.d/xencommons.in
> > index ccd5a9b055..36dd717944 100644
> > --- a/tools/hotplug/FreeBSD/rc.d/xencommons.in
> > +++ b/tools/hotplug/FreeBSD/rc.d/xencommons.in
> > @@ -23,7 +23,7 @@ required_files="/dev/xen/xenstored"
> >
> > XENSTORED_PIDFILE="@XEN_RUN_DIR@/xenstored.pid"
> > XENCONSOLED_PIDFILE="@XEN_RUN_DIR@/xenconsoled.pid"
> > -#XENCONSOLED_TRACE="@XEN_LOG_DIR@/xenconsole-trace.log"
> > +#XENCONSOLED_TRACE="none|guest|hv|all"
> > #XENSTORED_TRACE="@XEN_LOG_DIR@/xen/xenstore-trace.log"
>
> It would probably be clearer to untangle these in one go, leaving the
> result looking like:
>
> XENCONSOLED_PIDFILE="@XEN_RUN_DIR@/xenconsoled.pid"
> #XENCONSOLED_TRACE="none|guest|hv|all"
>
> XENSTORED_PIDFILE="@XEN_RUN_DIR@/xenstored.pid"
> #XENSTORED_TRACE="@XEN_LOG_DIR@/xen/xenstore-trace.log"
>
> I'd also be tempted to fold this and the NetBSD change together. It's
> not as if these bugfixes are distro-specific.
>
>
> It looks like a bug in NetBSD in c/s 2e8644e1d90, which was copied into
> FreeBSD by c/s 5dcdb2bf569. (P.S. Sorry Roger - both your bugs,
> starting from a decade ago). It really is idiotic that we've got a
> commonly named *_TRACE variable with totally different semantics for the
> two daemons. Then again, its far too late to fix this :(
Ups, sorry. Feel free to fix those in one go, and add my:
Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Thanks, Roger.
|
