[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] tools: remove unused sysconfig variable XENSTORED_ROOTDIR


  • To: Olaf Hering <olaf@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Thu, 6 May 2021 17:49:14 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MNmEysxKi1C8vLv+oGi3bIL1QdN9QGF6+tqFhukZcLg=; b=Yq1+FharPZQ/sf4TifOL+J8zOPKEzxsFVjfgwIQHx3cqrVSYL4ApVXMwe3can7U7IyU1qaOy8sV++Lnk2UZxnjA+6I2nfCvKPNkfR7qJkAP1kUvihCmAab9CAMoyJxprzaCukAGNt7x3jeXbrnKpX9eV2EDlh/R7IPB97Fubns4KqBBO5F0g54Qi/619faXbWeNqe310iWu8s9M4S5AVPMuFYtmB5A3gx05HT0sQitKMCD2pZPE1ae/nTBXV3DsYujYoQXddEjvJFlM2bRofRkLcK8uQ+/c2i0900xbLpIWEXVVgLs8o4HhIylq1v4swLGk/nAqHRzUXyMcyK00PKg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G0J+OrFYWvLqr4wYhhEOdu9THMw1eIDR5W3U/MZbVfK8epGRwEr+a6F26QR12p3/WTBAvSxhuXusLWShtTBW0swGnbj6rFpClMR462rVEvWc70hc9SroLULstfjp4Al523NEIL7w8e4GsMnTr1IV6G3icUz7KIxL/2x9oZHxgvCKbvd/CTP/zb6dWhxbE7AJjY+NSwLR9hNsbj9mr/utBS4y/9Sw9q5//bWgjj56DmNPD49+O3cseB9CeepvdpPNsKoI7E6Uh4U3E3bvu5iWm+eRkrDwCdckgHSE/MFrt2ybNT8V73H9y3A8kSJbAitpRwJ5WgMYy6N+RLWHX7T/IQ==
  • Authentication-results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Thu, 06 May 2021 16:49:34 +0000
  • Ironport-hdrordr: A9a23:Ccxmv672LRCYgpCN0gPXwDLXdLJyesId70hD6qkQc3FomwKj9/ xG/c5rsSMc7Qx6ZJhOo7+90cW7L080lqQFhLX5X43SPzUO0VHARO1fBOPZqAEIcBeOlNK1u5 0AT0B/YueAcGSTj6zBkXWF+wBL+qj5zEiq792usUuEVWtRGsZdB58SMHfhLqVxLjM2Y6YRJd 6nyedsgSGvQngTZtTTPAh+YwCSz+e77a4PeHQ9dmYa1DU=
  • Ironport-sdr: q1Kh7AZqKddfJKQ8PxL5eifappJWea3o4KrEF/4c/HLAQXHrksWJ4GGGri8SZZBC9Dzvb5TFGt V4DsEd5f7IELu8Mzaxs9ISHMtctGvlBcZRxmH8cEEujRg1MidZEWFOlF6BZ8gSoWU7cJcjnfZx 8LGZubgYWqopOkAPhiuviVR1QDeaChGCqaGKeszi0WStEcStMKzCKRaIoD9LB1GTMImZPFjek4 mPSvaciB0pcAe4cBBNmeh1RWrBJj+JEj4JOZDL4Y4nKAnB8bmgdHMwRWSRLstegPAoPfNoL8XM BK4=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 06/05/2021 16:16, Olaf Hering wrote:
> The sysconfig variable XENSTORED_ROOTDIR is not used anymore.
> It used to point to a directory with tdb files, which is now a tmpfs.
>
> In case the database is not in tmpfs, like on sysv and BSD systems,
> xenstored will truncate existing database files during start.
>
> Fixes commit 2ef6ace428dec4795b8b0a67fff6949e817013de
>
> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>

Acked-by Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, although as we're
trying to keep on top of the changelog this time around, we probably
want the following hunk:

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 0106fccec1..6896d70757 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -6,6 +6,10 @@ The format is based on [Keep a
Changelog](https://keepachangelog.com/en/1.0.0/)
 
 ## [unstable
UNRELEASED](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=staging)
- TBD
 
+### Removed
+ - XENSTORED_ROOTDIR environment variable from configuration files and
+   initscripts, due to being unused.
+
 ## [4.15.0
UNRELEASED](https://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=RELEASE-4.15.0)
- TBD
 
 ### Added / support upgraded

~Andrew




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.