[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 08/13] libs/guest: make a cpu policy compatible with older Xen versions


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Tue, 4 May 2021 17:34:12 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qcAE8UgSzLbxpyNcyOQZBf9t9rCKnTuTyD+W4zDbFJw=; b=L4I1U3CjDZvR+krKJ9rUjbFHqPf/mtalHQPUHBczMKo5BWHqPY3f6xXFPZWGdeXBD4PcG6Dd9vsQwfeH1cdbqk5dLeKl9+0VAGNg1r/IzGF+tN6jvd6tgmxaLmcM9UPu12+vkR3zIzUV/TssRVJUE7TfGHfjc52p3TLMMSjpbkBKtIIZGUItr7RHYFhKMDxINDJPDThVCrHRpk10L15U4TVV0tRyUsbAzj2g/k4h/O4Jbj5ctv4dRnDTpIYNfu7oTQgMuO4MWrMJ4J7p35KdROMAz+9C1HCLFk2JrSa+EQ6dqjxfJPJh+p/GHNYA4P3jr1Xk9Uy9iyY03SkJ9Ad6Pg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F55LPs8Bq1hb/PTsu3CesJMqu6GeuE3RBHH9tTeSUwJMHjOSbeaVzTqwweQcwJuX+g07YPwpR27xZVzbzfzyqfeeEf/0ppE2qF9/yMweeOTmXz2FBTkkMk2m1qmkz0TE6VXo1R+RmkkZrC4k1qZKYuFH+IHbWMsGZD0VQx8sHjabAkeVOuMtY3I8PR0p18zZiKws9mSodnAA1X8tbvd+tb3xqn7dfSZ3iy16Pm7mh8PV/FdXalYSLtQoahQ5JdLCsmIAgIDj4LppUclODiP2lxCOZgu0EHS829EJrRhbbgLf4Iz7Ia8SJAdkKZM0X0LFonsqFfErh/zdjTgb9R5x+g==
  • Authentication-results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Tue, 04 May 2021 15:34:42 +0000
  • Ironport-hdrordr: A9a23:ByxlH69KRr3arzgwz3Nuk+EKdb1zdoIgy1knxilNYDRIb82VkN 2vlvwH1RnyzA0cQm0khMroAsS9aFnXnKQU3aA6O7C+UA76/Fa5NY0K1/qH/xTMOQ3bstRc26 BpbrRkBLTLZ2RSoM7m7GCDfOoI78KA9MmT69v261dIYUVUZ7p77wF/Yzzrd3FeYAVdH5I2GN 69y6N81lmdUE8aZMi6GXUJNtKrz7H2vanrfAIcAFof4BSO5AnC1JfBDxOa0h0COgk/o4sKzG 6tqW3Ez5Tmid6X4Fv212jf75NZ8eGRt+drNYi3peU+bhnpggasTox9V7OFpyBdmpDS1H8a1O Pijj1lE8Nv627AXmzdm2qT5yDQlAwAxlWn6ViEjWDtqcb0LQhKdfZptMZiXTbyr28D1esMt5 5j7iaimLd8SS7kpmDb4ePFUhl7/3DE2kYKoKoooFF0FbcFZKQ5l/14wGplVK0uMQjd844dHO xnHKjnlYxrWGLfVXzfs2V1qebcJ0gbL1ODSkgGjMSfzyJbqnB/11cZ38wShB47heoAd6U=
  • Ironport-sdr: dPk1cbQX7YxhnjBTxDCZloHj9Y83NEOynDkfKcb5+lZyVwH6puZu43swMSLISVaAChOxVUaVc8 Qjyr/CAojXM73HD6x2aHngu6uuPZ3j4a7tPDZr1mrxNvIAp89DnHKE/yYaOojIPmCXdCIdNnFE Hz1MHMk7R/bGpM8ffCfSFEHRuyucf2P5LSS9upU1SFGCKaiJFcYSw3hFflAgP0OGea8PLkO8bv QIlthxLGQzfzKBSGXMkfC85e7rc3ayNDWWrOI/4aH0+dehh3DrgEjBV/Ce3LNS6Go8BOKFJa4I k/4=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Mon, May 03, 2021 at 01:09:41PM +0200, Jan Beulich wrote:
> On 30.04.2021 17:52, Roger Pau Monne wrote:
> > @@ -1086,3 +1075,42 @@ int xc_cpu_policy_calc_compatible(xc_interface *xch,
> >  
> >      return rc;
> >  }
> > +
> > +int xc_cpu_policy_make_compatible(xc_interface *xch, xc_cpu_policy_t 
> > policy,
> > +                                  bool hvm)
> 
> I'm concerned of the naming, and in particular the two very different
> meanings of "compatible" for xc_cpu_policy_calc_compatible() and this
> new one. I'm afraid I don't have a good suggestion though, short of
> making the name even longer and inserting "backwards".

Would xc_cpu_policy_make_compat_412 be acceptable?

That's the more concise one I can think of.

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.