[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 3/3] docs/doxygen: doxygen documentation for grant_table.h


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Luca Fancellu <luca.fancellu@xxxxxxx>
  • Date: Tue, 4 May 2021 14:33:02 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SCmY5xtt53UnXwyGAt02nSthVV0hK+IwmbNXSyzE5M0=; b=BaOGmWNj9qn6a4A49KOekS4SMq8FBvpy6ySmce38hFBc9hVnPPvV/IL83hkEu/BcuZZRBhqnHNNMJc9PHzuIE2Yd+NiwtbS7uiqQKrIkjy+2DXwT/2NeXF7XI0Z0CyYPEqU4HJojp2pYstMSNby/laHJTPgUeAvYhZskmFy9sLtlh2DA97oBfC6cUe0dJV0/nuQLv6VAWWE3i7UKvCDhuuqUQT/9il3LqhjE7RUm60QH9wuAC7h40wN6sthhL6Qxg7gM1osirXiaQN6wJyNnETRwjv3G8zyG6cO5Vk+ibDHRWOnMFl2rXS5/ub4PLkPDWQVcProCxlq6E+vVc3F1GQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fNlp0Q6R4CZilrtfRqyos78CaP3Hc8j1ddR0gSXtswQWiM4x+9o3lSzUvHhtGckYOpZw40zvXwVRggZ9EGnSEc3Be+5gypey+mII3RpeAxUU/WmQjosrF4mxZYqQu3G328+hEb2oob1Y7bzLPuxmYLRw9HW6upj1pnObQsYu/o6h5GH7c0vjc0ztY7VwXrIR/zzX8YJ0/0/XpG91gkvR0zFlMOdTuq59c0CTpIE7UNYhOY0i0hJQm8obPu2Er2+FPSM4xPvFYmRum1NPVW5imBYFMFcEQdpTxuvyCImCJVUm/j1liHJ7eAs3IgponsmjySjhjP4YBVs/NlUp/Cozzg==
  • Authentication-results-original: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
  • Cc: Bertrand Marquis <bertrand.marquis@xxxxxxx>, wei.chen@xxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Tue, 04 May 2021 13:33:35 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com;


> On 4 May 2021, at 14:28, Jan Beulich <jbeulich@xxxxxxxx> wrote:
> 
> On 04.05.2021 15:09, Luca Fancellu wrote:
>>> On 4 May 2021, at 12:48, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>>> On 04.05.2021 11:46, Luca Fancellu wrote:
>>>> @@ -451,11 +466,6 @@ DEFINE_XEN_GUEST_HANDLE(gnttab_transfer_t);
>>>> * bytes to be copied.
>>>> */
>>>> 
>>>> -#define _GNTCOPY_source_gref      (0)
>>>> -#define GNTCOPY_source_gref       (1<<_GNTCOPY_source_gref)
>>>> -#define _GNTCOPY_dest_gref        (1)
>>>> -#define GNTCOPY_dest_gref         (1<<_GNTCOPY_dest_gref)
>>>> -
>>>> struct gnttab_copy {
>>>>    /* IN parameters. */
>>>>    struct gnttab_copy_ptr {
>>>> @@ -471,6 +481,12 @@ struct gnttab_copy {
>>>>    /* OUT parameters. */
>>>>    int16_t       status;
>>>> };
>>>> +
>>>> +#define _GNTCOPY_source_gref      (0)
>>>> +#define GNTCOPY_source_gref       (1<<_GNTCOPY_source_gref)
>>>> +#define _GNTCOPY_dest_gref        (1)
>>>> +#define GNTCOPY_dest_gref         (1<<_GNTCOPY_dest_gref)
>>> 
>>> Didn't you say you agree with moving this back up some, next to the
>>> field using these?
>> 
>> My mistake! I’ll move it in the next patch, did you spot anything else I 
>> might have forgot of what we agreed?
> 
> No, thanks. I don't think I have any more comments to make on this
> series (once this last aspect got addressed, and assuming no new
> issues get introduced). But to be clear on that side as well - I
> don't think I'm up to actually ack-ing the patch (let alone the
> entire series).

Ok, at least would you mind to do a review by of the patches we discussed 
together?

Cheers,
Luca

> 
> Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.