[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] public/gnttab: relax v2 recommendation
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Luca Fancellu <luca.fancellu@xxxxxxx>
- Date: Fri, 30 Apr 2021 08:42:49 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=W8mWuvGkwapgAk0R2YH82Gc/Yo4jqu8ktC4qkn3vmlA=; b=bT2ubH6Xf8F0HsBlGxLKPKD3dQR1bDwNy2170SaQnyG/2PAVXjA4pLUmu/v8ZTEPl7GFLzMgs13xnTV/si4NgW2eOpPj5L43DXOdMfyZNpRrpqZL8jKO8uxm0BiXiVUviSvGpGnYOnwH2F78Bw+OP4ZgO8IyteEqW0B5gkP1PEAeMEbNsaN1VfiABtMurompwVZJDMW3x5/4+1Ri/HuYeE7Yl1Gtaad73y7SOxNpyrpb2UB+sv0+yrYX/UTc8JFs9njUzwYxftDXHJQ+WP2KoIw11fTTZPtPggnZBr91umyYcadMdb0a8Vj8x8lsT0emThJuV8+QNw0ROGpSXjyjpg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GMc1I63wrYhhkRONafGUNdawFkdpm5d3yvzLiF7dCkJEwbhPy8BqS7ZkZns9uWZnmMbkjkUtR/bkxo8HsPMLO4xLXiKeJpJehbbVwQG5Gte6r5BMgHhZlsWhrzbYO5+rio5qs0cOF2iM7+PcfWoG1low3yPihPtQQEGJ3K/J+Z+oc6FG6lXf3agXeZZ/Gmz4kpOTpIkhQSwuj3J7GuGBRhS/vI79Oq0nK9qYmXTHnZA/rkiMksu2whlSNQrHPdUEWy+4tDaCIesjhnpKJrNSO/sFwezxvEuf4/VDNSwpOcWIV9jBzOhNhieBeKLul44e/cQiYUvbL09v00eWC27qRw==
- Authentication-results-original: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Fri, 30 Apr 2021 07:43:16 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
> On 29 Apr 2021, at 14:10, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> With there being a way to disable v2 support, telling new guests to use
> v2 exclusively is not a good suggestion.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> --- a/xen/include/public/grant_table.h
> +++ b/xen/include/public/grant_table.h
> @@ -121,8 +121,10 @@ typedef uint32_t grant_ref_t;
> */
>
> /*
> - * Version 1 of the grant table entry structure is maintained purely
> - * for backwards compatibility. New guests should use version 2.
> + * Version 1 of the grant table entry structure is maintained largely for
> + * backwards compatibility. New guests are recommended to support using
> + * version 2 to overcome version 1 limitations, but to be able to fall back
> + * to version 1.
> */
> #if __XEN_INTERFACE_VERSION__ < 0x0003020a
> #define grant_entry_v1 grant_entry
>
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
Cheers,
Luca
|
