[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] x86/cpuid: do not expand max leaves on restore


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Date: Fri, 23 Apr 2021 14:47:53 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Jnq4QWgQAnfYyTiwX6AawNNC98MznjLUDFEqXz3Se+Y=; b=SpHcibr88fu0sEyp8ev1HR0fnx68pir7TCwXtqwzRDklhl8OEZO4OX2cYBXZ20Ucp9cJRAM7CWzIIHIcdvaa0E5uTBTOdj9YL6pMXFUxjnVt9/RC0mTl6a0ZJzRJtKbMF2VtJe3ZpmFPnIFqyfMFeR+ZjF3E9On6AoNmUrxttyyHV8wCHQMFYFlgYwG2rJBrDt8HSJhCYOgDV1N1WnwUe2ArEACPwF0kLg7fiLgy7jAz+aHb5AhK+pDTvFWnWdGAgcrDd5eAF8qu8udNRtXurgSqKu0ixACB77Omo9+7mqYuHan5dJ2tBhtNilZd+t1Tei9PQ02JIfhM6gSE7m/IeA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XFZhsILfsoWFx1472h5myNqXYNBx603ujaPIZKgdrRw/YVqqaR+B6BEBxSzdo8b7QMi16BvKyMZn9hzysqDd7aEhu/qkHmOKK4s7kkoZpiRvSii6H30BFHZIDl2YNcCkRoMcFsBec+Vtk5FCk2yP9kt3xNjhr26TQYMbzf+GOSVp9p8dBZn/9oOYM241eMM8gop59rCgUGxo6hED8jyIHBeK/ZiXVDjuAr7GfmkXflLtUhb2PXeMFl7vdAXAZROLNJLzHPq+kxS7JfDplZT2+QF6+Z0YHkRbXe3ZiI5kCPRQuTj8K1qLJYD9Tmkgpffs+BlUOjBVPupMpQJWweQmvw==
  • Authentication-results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Fri, 23 Apr 2021 12:48:06 +0000
  • Ironport-hdrordr: A9a23:Cy95hq3pBmR8yDQqBVDiEgqjBWByeYIsi2QD101hICF9WtCEls yogfQQ3QL1jjFUY307hdWcIsC7LE/035Qd2+ksFJ2lWxTrv3btEZF64eLZslndMgDd1soY76 dvdKBiFMb9ZGIRse/W6BS1euxO/PCp66at7N2x815IbSVHL55t9B14DAHzKDwSeCBjCYAiHJ SRouprzgDQGkg/VciwCnkbU+WrnbSi+K7OWhIaGwUhrDCHkDLA0tXHOiKF1RQTWS4n+8ZBzU H5lWXCh5mLgrWA5TL3k0TS6JlXn9WJ8Ko/OOW8zvI7Bx+ppgKhZIFKU6CPsjYvsIiUmSoXue iJmTgMFYBe7G7QY3GUrHLWqnbd+Qdr0VDO4xu5hmbuusPwTj5SMbs+uatpNiH3xmBlmfMU6t Mt40up86B5IDmFoQHGo//PbB1unlrcmwtYrccjy0ZxfKFbVKVctuUkjSVoOaZFJg3WwqY9Ht JjCcnNjcwmC2+yXjTism5jzMfEZAVLIj62BkwLusmi2zNLhnxOz0wB2MwFnnsbnahNM6V52w ==
  • Ironport-sdr: PWi+Cxe6bMidLJ3oecWxtvYAtDHp5VUmwlJKYRZ1orekFE5WKq3Mx16ybfcSPaeMxH/e1SjjlW sWCvcHZ1CXEF9jhy8heXhleijZha6EmHIyqnxc8xu5UMlinpdVrboonZAboEbdIr6Qau7u5KqG /LUTHOz8oW1aYkCgiTujJcEv+iKu+BUUv8TR4RwSIYydmKYEvVIjTgkO3pO05tDY6XJFJZ4xxR iVIT99LobtGG+GGLxiiBCUmKTCPB73w8MaSa404TcWzN1c5LVWBM7+qol67gYlR+30MPqm/Ifu TU8=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Fri, Apr 23, 2021 at 02:41:32PM +0200, Jan Beulich wrote:
> On 23.04.2021 12:54, Roger Pau Monne wrote:
> > When restoring limit the maximum leaves to the ones supported by Xen
> > 4.13 in order to not expand the maximum leaf a guests sees. Note this
> > is unlikely to cause real issues.
> 
> Why 4.13 (and not 4.12) here when ...
> 
> > Guests restored from Xen versions 4.13 or greater will contain CPUID
> > data on the stream that will override the values set by
> > xc_cpuid_apply_policy.
> 
> ... 4.13 already communicates the values?

Urg, yes, my bad. This should have been limited to the max leaves
supported by 4.12, not 4.13.

Let me send a new version also incorporating the feedback from below.

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.