[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v10 00/13] switch to domheap for Xen page tables
- To: Hongyan Xia <hx242@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Thu, 22 Apr 2021 18:28:05 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EovWUtL7Nh59uUREfHZ4XyKAUoEq0RyzXKFwOVzdmOM=; b=MSdKZLEJli0C65vMVaXXt7Ng2VSZaz3MKzy8OAkhoHgl3lXo2U/h2umQLAImeEDtvz+8T7FZg1EhcM5l91t8Cedsmlm3l5NhYOk5eKSrS3Buo7Kh7kTHtDeuuYJIlaQOlitAxcVEcWSbyPt8BNjrQqJ/db/9HfOoBxIkbPC+yF5M6cdH4LL4DoAOXfD7au0hLC79bJkUnw3M1TyL3bgnRa5jiqEqpMvsBHC/vOGe0NMIJwSmd2OyfrDqtFdAZdBvHQTvURfNzXzFv61KLQjon5swUym/pPUGknjay96HBAIoN4bpkmyD6sSQ6qJSbQ4Z/WgkKLe3+Y8wvK8wUISS9w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FEKOuCmUGYk5DYj+mqlPZuDV5Jlo/phVYmotPHGfbbP6onwvJqX3mPlUSDETPTNvGlYG2kodODQOKj1EiEZnjWBei+Z1sH2BDZEpjcrvrHIeA51QuzjlePOJDTfiHFCA3gWMDPJxO1Tf/IT15MOiGYVbjdWKRfOdYsa1md8fQvc7ftP3l9i18hC7gvLTvf77Hh5g03OCItrr29o+sCFEm/bJoDcCzKE4ZA4GRzgFNSFMvS73SnMEmeinAyhFbVjLJTc68LEuuB4h322nWdIukwqfkOV0AXbzxvhP855yY26BwYk7ObfGGxKC8zH0jWQjIjwWto7TGvxb/pqM/Ebcrw==
- Authentication-results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: <jgrall@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Thu, 22 Apr 2021 17:28:22 +0000
- Ironport-hdrordr: A9a23:WnVvWaFyWJHYbq0epLqFtZHXdLJzesId70hD6mlaTxtJfsuE0+ CC9c5rrSPcojAXRX0mhJS8KLCNKEmsjKJdzKswGfOZXAfgsHa1N40K1+Df6hDpBiGWzI9g/I h6dawWMr3NJHxbqeq/3wWiCdYnx7C8gcWVrMPT1W1kQw0vS4wI1XYcNi+hHkd7RBZLCPMCff Ly2uN9qyOkaTAraK2Adxo4dtLerN7Gno+OW29hOzcb7mC1/FGVwY+/ODPd5RsVXypTwbEktU LClxX96riu2svQ9jbsk0T31tB5pPvNo+EzY/Cku4w/DwypqiGFWb5fcdS50gwdkaWO0RIOkM PQrxAtJK1Ihk/5TyWUmF/I+ySI6loT10M=
- Ironport-sdr: GV1fS06GGNW/xoko4W3FxYobXJbSRRrk6ohuPPy+UkaxNJEt9dkO/O3enPTIrCFBcvQ3nxXl5i kogFjcP0qj3F2zGtOPKMURRSGvbIydyRBnM5m+VHJ0qrDyQdBQmiMIW/jIcylgbbMOgk3L9+1A 1jJYD5kKswntRSBjwUfyvc0QjP25/byjq169Se0UbrEUXSjYCOaEaVymw8Q+EMqhvlLXFutDYA NOmMhumORy02Qz+Y3vhnBCEz/yNYcqosxSkebJXTPgPLB/p1qihZW798STiTu38k9dWiVGr47M MyI=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 22/04/2021 17:35, Hongyan Xia wrote:
> Please see my reply in 03/13. Can you check this diff and see if you
> can still trigger this issue:
>
> diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c
> index 50229e38d384..84e3ccf47e2a 100644
> --- a/xen/arch/x86/mm.c
> +++ b/xen/arch/x86/mm.c
> @@ -5532,7 +5532,6 @@ int map_pages_to_xen(
>
> out:
> L3T_UNLOCK(current_l3page);
> - unmap_domain_page(pl2e);
> unmap_domain_page(pl3e);
> unmap_domain_page(pl2e);
> return rc;
> @@ -5830,6 +5829,7 @@ int modify_xen_mappings(unsigned long s, unsigned
> long e, unsigned int nf)
> out:
> L3T_UNLOCK(current_l3page);
> unmap_domain_page(pl3e);
> + unmap_domain_page(pl2e);
> return rc;
> }
Yup - that seems to fix things.
~Andrew
|
