[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 3/6] tools/libs/ctrl: use common p2m mapping code in xc_domain_resume_any()


  • To: Juergen Gross <jgross@xxxxxxxx>
  • From: Christian Lindig <christian.lindig@xxxxxxxxxx>
  • Date: Tue, 13 Apr 2021 15:00:09 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZQW+xYPh6pAcVZBk/yiOOXBIDl4Fenh/P1Mq6G9poHY=; b=dP5ZQTO3fUwBYjNplAfJWCZr1xSiYi9gLkoAr5v7pTUfgod2wf+6WQKdxNDmboLFhrVHCQxIKG6kih9DXz/ACbUyVVMjdPNR1IArDdd0xG/MuBUIpd5EE/dRPU+PW1IQ27Cnfr+byy1RuPF7Kg/K1b9zruGJTqzg1UpCRKGsiA/FwURIoeZy85bmjEcFzg/UvEDinPuyDG6k6H9vrFBv+Anhgl6ASdVu7YhRfBhRAe3VdIK+5CbeZuyc+sqYozBFRdNSZdgvDlJq+/8yO0W9V2WMrQwHQxzeJfh80IGz2kXe6jE/f7qxfHxrHq4XDoL751JJtl2aCVLSj/mTJkQ19g==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=juqfoYocTJIVPJjaQBnk9kAiyLoCwqiN0oxZ86XNL5j57rO8aZnDcZJpheOfozPjihmG6Qj02CpErS/KcLQZFEYWOdj2wdnRQ0QtGlZ3+pPcgtejL7jhAc6JB372Ud0BobiDAywRqerxVRwVoGREhX16KCtJWIoP/jdR6JTSE9IUfqVwdFjsAURRGbYXRjDX+4Qyn9JMwYosLpQVzCNYy97pCLoKbti5KMwhxBsa7uLqm9uDJtIcqFMkm4+VfveXCxXrPaOvIYFgjXDoc3g6AGUooFKd6dr60oCuK5EUCvMSX+ztt4yBMJl3gG2IqgrqIYC9IoOb9j8+0Do5zSO/9w==
  • Authentication-results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Ian Jackson" <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, David Scott <dave@xxxxxxxxxx>
  • Delivery-date: Tue, 13 Apr 2021 15:00:19 +0000
  • Ironport-hdrordr: A9a23:HkBpVK0MOHdUm18MkU1yZAqjBWhyeYIsi2QD101hICF9WtCEls yogfQQ3QL1jjFUY307hdWcIsC7LE/035hz/IUXIPOeTBDr0VHYSb1KwKnD53nbGyP4/vNAzq sIScJDIfD5EFQSt6nHySaiFdJI+re62YSJocub8Ht3VwFtbMhbnmVEIyKWCFd/SgUDJbdRLv qhz/FKrTahZngbB/7TbhU4dtPOusHRk9beaQMGbiRN1CC1kTiq5LTmeiLovSs2bjUn+9Yf2F mAqSPVzOGJs/a3yhjTvlWjlah+qZ/a5fZoQOCJgsgRAD3whgivf5QJYcz+gBkF5NuBxXxvvN 7QowoxH8kb0QKsQkiF5SHD9iOl8DEy52TswVWV6EGT3vDRdXYBJOdqwad6GyGpj3YIjZVH/4 9gm1+9jd5xCyjNmSzsjuK4Ly1Cpw6PjlcJ1dIIg2c3a/p4VJZh6bYx0WlyC5k6ECfz+OkcYZ JTJfCZ3vpQfF+ABkqp2FVH8ZipVnQ3KB+MXlIPjMyTyyRXh3B01SIjtbUioks=
  • Ironport-sdr: Lcq8ByzOzGWas/782Fc6QBIujTlVoNAq1CcJXinhudrbLiB02EadTUJ2LB7e8nfR2yTFcpL5FG uiN3LPEMa9daBXmaVVWBfhE/gsQfw/3O7Quj9HPw89Ouil/5RDgjqoptY6QhWiMZZhleEMvyOL +BinOHJwrmabZswoIM09bKPwqq//A0SCd39ofxsWBNfZX2ssR6FUxs4e+4NskgIxAZDaEr2cgi ztZDXqJNuIRF6eakQkRrvduVUbw72P/HpfNYsNgWKUnZIl5rcIoFjVXKObCT808B46+60u8dNW /O4=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHXL6/OkwM8g8S8xkOjh61WGG0vPaqyjAMA
  • Thread-topic: [PATCH v2 3/6] tools/libs/ctrl: use common p2m mapping code in xc_domain_resume_any()



On 12 Apr 2021, at 16:22, Juergen Gross <jgross@xxxxxxxx> wrote:

Instead of open coding the mapping of the p2m list use the already
existing xc_core_arch_map_p2m() call, especially as the current code
does not support guests with the linear p2m map. It should be noted
that this code is needed for colo/remus only.
[..]
diff --git a/tools/ocaml/libs/xc/xenctrl_stubs.c b/tools/ocaml/libs/xc/xenctrl_stubs.c
index d05d7bb30e..6e4bc567f5 100644
--- a/tools/ocaml/libs/xc/xenctrl_stubs.c
+++ b/tools/ocaml/libs/xc/xenctrl_stubs.c
@@ -32,6 +32,7 @@

#define XC_WANT_COMPAT_MAP_FOREIGN_API
#include <xenctrl.h>
+#include <xenguest.h>
#include <xen-tools/libs.h>

#include "mmap_stubs.h"

2.26.2

Do we need this when there are no other changes in the file?

Acked-by: Christian Lindig <christian.lindig@xxxxxxxxxx>



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.