[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH] x86/EPT: minor local variable adjustment in ept_set_entry()
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: "Tian, Kevin" <kevin.tian@xxxxxxxxx>
- Date: Tue, 13 Apr 2021 02:52:33 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UsGR47VZ6LlNbIF+aGq5d+PZreWpD7X5loHU2IL/6Ts=; b=YM6Ph651NPxAdYoUx1/ckJhts6sG/xMkoQ7DVHaDXS+AiONWVoNlWD1s0QAf96mwmhxFdMq5pngRWdz5JVPNbaHHoQTDiL4B/LSGFUNtPCZJA6zwVSd0IRD1FP2LCcF2Tiko5QAaJi+dZKkwzsNCYf5PaT1+5py/B1T+OB03qQy5DTuZ+QA0P87usrgXdEUJQXxW42NFb9q5dgkDMLX7NlGGr+Tpq7mcxzt8fkwB+xz/g3nSH8kiKuShkmqF3+cfU3l+ioUHmV2rKmTLxWBfVBa4nT8yDmhyPIXQa8iX4I3WqikiknjcNRhDM47G2erA2qAbU4PjZjzEa7kg+TUgsw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TUoVuXdkNTmILCdrH2WFaVjWHTT7fRPAJSsJFW86JusHIPfY+3H9/2J4EL11FxYNI7cRN2MBu4Q769KSwjguAF1hWcNnnbsioje74gf5TiWWOsnkZqYkY9J80Yln8BSmitT3M9HIzDU/Fbf+S7UAK76YxbfirAW8Q4Zen2XatQDofVEHA7X7fYHhX5n23TokmiNVQp6ic5fDXb80aTPrc6Glo9y9omzdJzckBX8oywu8ctcOA6wuvbpq1YCVJL3OLzQem/kpi/Sxdwkw8gJpSsuyDXf9gHiC2kk1ppkKG+ATEsHRF4HC1LVv75tVlaXRr6THTy1tn4rbD4oWECjrJw==
- Authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=intel.com;
- Cc: "Nakajima, Jun" <jun.nakajima@xxxxxxxxx>, "Cooper, Andrew" <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Tue, 13 Apr 2021 02:52:44 +0000
- Dlp-product: dlpe-windows
- Dlp-reaction: no-action
- Dlp-version: 11.5.1.3
- Ironport-sdr: j1UZXAjbmp0lrETWFzRgE4xU9R/vKpk4D5/U7clvxfDjMjEWnqjqCtVTxszT6P906pqern+suf 16OhZAxY1wuw==
- Ironport-sdr: 05ZLCTlBQPW7/R2xxJ+3E4a4UAGCL9HR7k8eHy8ggOip3kuyBv/nOXVtHr0xOqWo1Zz2CRWAAr KyjYzzP1s1YA==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHXL4+7dnXIvXPTUkGtk5FNTmUwKqqxwNuw
- Thread-topic: [PATCH] x86/EPT: minor local variable adjustment in ept_set_entry()
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: Monday, April 12, 2021 7:34 PM
> Not having direct_mmio (used only once anyway) as a local variable gets
> the epte_get_entry_emt() invocation here in better sync with the other
> ones. While at it also reduce ipat's scope.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>
>
> --- a/xen/arch/x86/mm/p2m-ept.c
> +++ b/xen/arch/x86/mm/p2m-ept.c
> @@ -677,8 +677,6 @@ ept_set_entry(struct p2m_domain *p2m, gf
> unsigned long fn_mask = !mfn_eq(mfn, INVALID_MFN) ? (gfn |
> mfn_x(mfn)) : gfn;
> int ret, rc = 0;
> bool_t entry_written = 0;
> - bool_t direct_mmio = (p2mt == p2m_mmio_direct);
> - uint8_t ipat = 0;
> bool_t need_modify_vtd_table = 1;
> bool_t vtd_pte_present = 0;
> unsigned int iommu_flags = p2m_get_iommu_flags(p2mt, mfn);
> @@ -790,8 +788,10 @@ ept_set_entry(struct p2m_domain *p2m, gf
>
> if ( mfn_valid(mfn) || p2m_allows_invalid_mfn(p2mt) )
> {
> + uint8_t ipat = 0;
> int emt = epte_get_entry_emt(p2m->domain, gfn, mfn,
> - i * EPT_TABLE_ORDER, &ipat,
> direct_mmio);
> + i * EPT_TABLE_ORDER, &ipat,
> + p2mt == p2m_mmio_direct);
>
> if ( emt >= 0 )
> new_entry.emt = emt;
|
