[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] xen/pci: Gate all MSI code in common code with CONFIG_HAS_PCI_MSI


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Rahul Singh <Rahul.Singh@xxxxxxx>
  • Date: Thu, 8 Apr 2021 08:45:06 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CYZ3yCgEnuXY/2/qF5qLs1x7J+PBf8WlWhcVPeoUUbc=; b=MLpI+4Ek0lsTX/1bOPn3nGdPxTuGh0FsVAU23CKI9WoF6gGLHOayggwaQ+GglIBMpNMCERwhC12NLApoS1nBMunM7oaZPN4TDiX4A5fkAzPy1p6D+kGvcTViuNfC8d0RYpSIYhvnuWBbu/Hpa1mdGQGl5RhFrpIX8E/Xh6zlAxwVjUg2y179hQXMyf9Z/H249tfWGn0aWfBhYpck7FPuqckjS24u2FKoAJKpc3u/gjn5ReF1/3EQiYLNb5OoZ/IKopLu/GkwJ/08iZWStItrGhSjqun9pwAe/cn6IO6cerTEILfH1joxZLGe7Q34w4VrSvRX0f/IFZibxt/MtTNB+g==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N3o7M7bc8PKxLF0o7IZEj/EDaW3FhyujjGuR4UstQPodgXohfv5kN7NvWJlRuaT1dryqnodoJ9sZLiGvUXXBdRmcW9KVFTCNV5ghNogFsd9uHQTDcxlu0eeN9cffzFFzxV1t1KYo3d66aDYt7CxGldNCaF+lTGQ7eY/pQZgrDFQXsdHq1F9+d6xzlJ0QI4W4FZqJ18vnKqH5bm2ZWD/LK9U7pCt00MzaCdPzqp499y8IMPFH0tEHMDUySvxHLp7xN3Coc8Km4/LRU1PIiY7mMhNT7tW8JUX4orrIbG8UG3d5nexBKRp6VRW0VK6DfnlCjMnuds+/jFGLfToxLVYR1w==
  • Authentication-results-original: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
  • Cc: Julien Grall <julien@xxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Paul Durrant <paul@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Thu, 08 Apr 2021 08:45:52 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHXKtnMgQfSb5EUJ0m5ImZxjYO+aaqniEaAgAAErYCAAA9rAIABv2eAgADHeYCAAC39gA==
  • Thread-topic: [PATCH 2/2] xen/pci: Gate all MSI code in common code with CONFIG_HAS_PCI_MSI

Hi,

> On 8 Apr 2021, at 7:00 am, Jan Beulich <jbeulich@xxxxxxxx> wrote:
> 
> On 07.04.2021 20:06, Julien Grall wrote:
>> Hi Jan,
>> 
>> On 06/04/2021 16:25, Jan Beulich wrote:
>>> On 06.04.2021 16:30, Julien Grall wrote:
>>>> Hi Roger,
>>>> 
>>>> On 06/04/2021 15:13, Roger Pau Monné wrote:
>>>>> On Tue, Apr 06, 2021 at 12:39:11PM +0100, Rahul Singh wrote:
>>>>>> MSI support is not implemented for ARM architecture but it is enabled
>>>>>> for x86 architecture and referenced in common passthrough/pci.c code.
>>>>>> 
>>>>>> Therefore introducing the new flag to gate the MSI code for ARM in
>>>>>> common code to avoid compilation error when HAS_PCI is enabled for ARM.
>>>>> 
>>>>> Is such option really interesting long term?
>>>>> 
>>>>> IIRC PCI Express mandates MSI support, at which point I don't see much
>>>>> value in being able to compile out the MSI support.
>>>> 
>>>> I am pretty sure there are board out with PCI support but no MSI
>>>> support. Anyway, even if the spec may mandate it...
>>>> 
>>>>> 
>>>>> So while maybe helpful for Arm PCI efforts ATM, I'm not sure it
>>>>> warrants a Kconfig option, I would rather see Arm introduce dummy
>>>>> helpers for the missing functionality, even if unimplemented at the
>>>>> moment.
>>>> 
>>>> ... from my understanding, most of (if not all) the MSI code is not very
>>>> useful on Arm when using the GICv3 ITS.
>>>> 
>>>> The GICv3 ITS will do the isolation for you and therefore we should not
>>>> need to keep track of the state at the vPCI level.
>>> 
>>> But that's then not "has PCI MSI" but "need to intercept PCI MSI
>>> accesses", i.e. I don't think the Kconfig option is correctly
>>> named. If a device with MSI support is used, you can't make that
>>> MSI support go away, after all.
>> 
>> That's actually a good point. Rahul, do you think the config can be 
>> renamed to something like CONFIG_PCI_MSI_NEED_INTERCEPT?
> 
> Minor remark: In this name I'd be inclined to suggest to omit NEED.
> 

OK . I will use the name CONFIG_PCI_MSI_INTERCEPT and will send next version of 
the patch.

Regards,
Rahul

> Jan


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.