[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/3] docs/doxygen: doxygen documentation for grant_table.h



Hi Luca,

On 07/04/2021 14:19, Luca Fancellu wrote:


On 7 Apr 2021, at 14:13, Julien Grall <julien@xxxxxxx> wrote:

Hi,

On 06/04/2021 11:36, Luca Fancellu wrote:
Modification to include/public/grant_table.h:
1) Change anonymous structure to be named structure,
    because doxygen can't deal with them.

What do you mean by can't deal with them? I had a quick try with doxygen build 
and couldn't find any failure (although I haven't looked at the output).


Hi Julien,

The problem is that Doxygen can’t generate proper documentation for anonymous 
union/structure, it ends up with warning and/or producing wrong documentation like
changing names or giving field description to the wrong field.

I might do something wrong because I cannot spot any significant difference in the doxygen ouput if I switch back to anonymous union. Would you mind to post more details (such as a diff) on how doxygen doesn't generate properly documentation?

Cheers,

--
Julien Grall



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.