Re: [PATCH 08/14] tools/firmware: hvmloader: Use const in __bug() and __assert_failed()

[Julien Grall <julien@xxxxxxx>]

Hi Roger,

On 06/04/2021 08:29, Roger Pau Monné wrote:
> On Mon, Apr 05, 2021 at 04:57:07PM +0100, Julien Grall wrote:
> > From: Julien Grall <jgrall@xxxxxxxxxx>
> >
> > __bug() and __assert_failed() are not meant to modify the string
> > parameters. So mark them as const.
> >
> > Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
> Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Thanks!

> While looking at this I think we should also make the line parameter
> unsigned, but again doesn't need to be part of this patch.
I would prefer if this is done in a follow-up patch.

Cheers,

--
Julien Grall