[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 2/2] x86/vpt: Simplify locking argument to write_{un}lock
- To: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Tue, 30 Mar 2021 09:36:15 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=525GPiB0IPOPfB0ATOYfQQh19wiwQ8jGEvUEH8Nje6g=; b=e2Z4I0ziZHVhDlJ1roE8JCBgMkixzhPUacUfOzhKWyrnJr3+KAR2gcgZLG5jdSMnhX3fm18BFb9UrD7/bn+buNZN8VQlujLMv75b0zoFvVEUGmx3yKaw4mG5k8XgTznU7bDItBcJAdsgrB2TlvLW+JFtpIABkFXS2L96wMBAW8yz7g70Wm7khUnYRPDB3uyyhAF5RXhG3n8FWFhWSzO9Q9rnjtlHzInNcndtigbBRsMHadyUxD4HFRXehqiVCWiut7LLgi6XKNpPs/qUe9L3A8pSqkdvR9Y6evi7kjOszfxlKuvVwJ3NwwEn6oyHqA69dgoVPkn3LkZRktzVEza7rw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cZt756R/PvSgMhSjqcFoX8psWt/GEaACfYWPyvfl68NRM2ucA8lMZIdCizRLlTEirWr3Veu3yiIa90Rqzcz2Oy+dS9AAGpiaIQBPO8f/p8/4xUtdRZrg5hUymiFKtUQE1xSG4z3hUpjeLPTd5QYzwZd8gpP/ONf0W/zqJ8wQFpmP3nXDEA8q32c+ME7pQF0rAAHTmFjTxnXa+En56y2ZmZGI0cLHBx2TI3kNPvYzO0hHScsu+mxFoWRoecU3UCdG0eMdca2lY6X+N43O2zaxGj149IHs8bp8XFbDtFfEzsfIkqtK4nLouSN1h/k2l5FNYniqqI5aY0//b2EiX897rg==
- Authentication-results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, <jbeulich@xxxxxxxx>, <andrew.cooper3@xxxxxxxxxx>, <wl@xxxxxxx>, <stephen.s.brennan@xxxxxxxxxx>, <iwj@xxxxxxxxxxxxxx>
- Delivery-date: Tue, 30 Mar 2021 07:37:15 +0000
- Ironport-hdrordr: A9a23:rGgBWa6747ApFaST3APXwXiEI+orLtY04lQ7vn1ZYSd+NuSFis Gjm+ka3xfoiDAXHEotg8yEJbPoexzh3LZPy800Ma25VAfr/FGpIoZr8Jf4z1TbdxHW3tV2kZ 1te60WMrDNJHBnkMf35xS5Gd48wN+BtJuln/va0m0Fd2BXQotLhj0JbTqzOEtwWQVAGN4VFI CE4NBGujqnfh0sH76GL1MCWPXOoMCOqYnvZgQICwVixA6Fiz6p77CSKWnk4j41VTRTzbA+tV XUigCR3NTZj9iX6D/5k1XS4ZNfhcf7xrJ4avCkp8AJJlzX+2SVTat7XbnqhkFRnMiO7xIQnM DIs1McOa1Img/sV0WUhTeo5AX6yjYp7BbZuC+lqF/uu9bwSj5/K+cpv/MhTjLj50AtvM5x3c twtgrz3fonbmKzoA3H69fFTB1snEavyEBS6dI7tHBDTZAYLIZYsI13xjIlLL47ACn45Io7ed Meav302fA+SyL/U1np+kNrwNCqQ00pGAaHTkUoqqWuokZrtUE84E0CyMMFmHAcsLo7Vplf/u zBdp9ljbdUU6YtHO5ALdZEZfHyJn3GQBrKPm7XCVP7FJsfM3aIj5Ls+r066MyjZZRg9up8pL 3xFHdj8UIicUPnDsODmLdR9ArWfWm7VTPxjulD+plQoNTHNfrWGBzGbGprv9qrov0ZDMGece 20IohqD/jqKnarMZpV3jf5R4JZJRAlIYwok+d+f2jLjtPAK4XsuOCeWu3UPqDRHTEtXX66LW AEWBT1OcVc/mGmUnL1m3HqKjHQU3262ag1PLnR/uAVxoRIHJZLqBIphVOw4dzOCTAqiN1yQG JOZJfc1o+rr2i/+mjFq09zPABGM0pT6LL8F1dDpQoANVLIYa8O0u/vPVx67T+iHFtSXsnWGA lQqxBc4qSsNaGdwigkFpaBPn+FiWAQ4FaHVY0VlKHGxcqNQOJ3Mr8WHIhKUSnbHR18nghn7E 1ZbhUfe0PZHjTyzYO/jJIVA+nbX8JmgBiiJPNVrX63jzTemegfAl8gGxK+W8+ehggjAxBOgE dqzqMZiL2c3Qq0JXAHm+Q+Ol1UYGGxCLZLZT71I7l8q/TOQkVdXG2KjTuVh1UWdnDx/0sfvG DnMBaZYOrGGFZbp3Be3Jv76V8cTBTvQ2tALlRB9aFtH2XPvXh+ldWGYae+yEO9QFoPyON1Ck CPXRIiZidVg/yn3h+cnziPUUg8zpI1J+rHEfAIaLfIwE6gL4WOiIALF/JZ54xeKdjrq+MHON jvPTO9HXfdMacEygaVrnEqNG1Is3Eii+rvwwCgw26i3nIzaMCiVmhOdvU+GZW74GflTfrTj8 k8otIxoOeqMmL+LvSB0rraajZfKhXV5U66JttY3ax8jOYXjv9UGZKebB7jkFdg9z86JN3vlE wfTL9giYqxcrNHTog3QWZh4lEtlN6zN0MlvQz9P/8mcTgW/grmFuLMx4CNlKEmDUKArjbhIF Wz8yVS+PHeQiuIvIRqfJ4YECBzaEIm7m5l8/7HX4rMCB+yf+UrxivxDlaNNJtcQrOCA7Mes1 JT5MyJhfaec27d1BrLtTV2ZoJI/GDPe7L+PCu8XcpJ+ce9I1KCn++D59Oyli7+TX+DUHsj7L c1PHA4X4BkkTktjIo+zyi0ROjWmyse4iRjyAAisEXs1Iig6HrcBmdcP2Ti88xrYQU=
- Ironport-sdr: WxKklPlqZSGexaY34wYBVWt73qHxfuy8l4nrmipXy1TNpGz6ZSIhgwTIjQYyh8ZeszBzSORGpw cVhuoe2pkVHXXLhe5XXsFojXmkF6ibak0YI2YkH2L5P0Uw7EBHPwQ9Xt44REiPhbEFvhHRDOXn SGShtJGty3oy2jd54ltCT2b/ni6OK9n5g5Gf3Sj8ufqhaxJWlGTkHGFzibIvB40Elw6/GAzD/6 Beb1fR0JupHMc9CDk0vOtUVO+DJ20IIuKj3ESc6CnxYxvyBEFppDWt/RgQzjZUep/2h+f6TMkf Bco=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Mon, Mar 29, 2021 at 05:15:02PM -0400, Boris Ostrovsky wrote:
> Make both create_periodic_time() and pt_adjust_vcpu() call
> write_{un}lock with similar arguments.
>
Might be worth adding that this is not a functional change?
> Requested-by: Jan Beulich <jbeulich@xxxxxxxx>
> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
Either way:
Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> ---
> New patch.
>
> I ended up doing what Jan asked --- create_periodic_time() is also using
> different
> start pointers in lock() and unlock().
Hm, I'm not sure I'm following, create_periodic_time uses 'v' in both
write_{un}lock calls, which doesn't change across the function.
Thanks, Roger.
|
