[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] x86/hpet: Don't enable legacy replacement mode unconditionally
- To: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Thu, 25 Mar 2021 17:00:55 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ux+DkcVLmnAoFtLq5LB3V6huJv5fnM7DaMb63yfG/v0=; b=OEfpORitd/JeX21uodOQioOurV5vUdxzNHT4jLBs4v9Tbvd/WHUrm4bJE79KxprXeEjf2BDvFa2k84W2TDnQHL7nrWEwpPUk+ESGUh1PeNEjLOle9iAQzaIu4yod+Ces60PKhZOmEjANJPSSXbxXgiq6rBw4QXtErEb18aTPfTrrYkGWwceWQqfwIhfWTFBqrd7We+G73PmGtJZbe+zWOfhigfI9RiW5hZ3rLFBEBUS+QlJvlshtHH5KCd1JQS4AGvIEohLjjngakj6WU5+gEzBkX6+O0xNoed9RVjOn9ItbZHTA4kItzwKiyn/4//8WEVjx5skUakeaRa/h/ciwAg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RgI5tVdC+N5xe70hD/0W3p4+19VJUM6PE5UXVHygNC2lUevSSEUeqRFNYxovYtxPdBNc4a0a9Dw0D49yFIfxzcPCxmETFt3UZJQu/Q1OOob9rw1Gym020G+hnEOgXfVxv+a9bMJ/3JlKJN4p2jzOfApUyoljOg+7bDz9u+uWUib3Pd4oUgTfcfdRL0cMoV8kM/csHFFagjjM77ic/kPvvcO25BOqXcXu5OwYqpKdvfSKG43Qo7g3gR31qAQkOJpnWmZBGRix//X6ig2hHKwWpXg/CZCOX4SlgEi5mbikYXZqPqrCoToVne0gB10PZHhtAN1bqMhwUDi08JJ/Gmd6ug==
- Authentication-results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, Frédéric Pierret <frederic.pierret@xxxxxxxxxxxx>
- Delivery-date: Thu, 25 Mar 2021 17:01:10 +0000
- Ironport-hdrordr: A9a23:VmQcRarhom+7SFMXhcxCy+oaV5vYL9V00zAX/kB9WHVpW+SFis Gjm+ka3xfoiDAXHEotg8yEJbPoex7h3LR+iLNwAZ6JWg76tGy0aLxz9IeK+UyHJwTS1M54kZ 1hfa93FcHqATFB5/rSzQGkH78br+Wv37uvgY7loUtFbQYvUK146hc8NwDzKDwVeCBjJb4UUK WR/dBGoT3IQwVxUu2eCmMeV+bO4/3n/aiWAiIuPBIs5AmQgT7A0teTfySw5RsQXyhCxr0v6w H+4mnEz56uru2hzVvk33LThq48pPLa1tBBCMaQ4/JlTgnEtwDAXuVccozHhh8ZiqWF6FEmkN 7Dyi1QQPhb2jfqUUye5Tfo0wnk+j4y53Hl0k/wuwqcneXJAAgUJuAEqYVFcgbIy0dIhqAM7I t7m1i3mrASLRTckD/z79LFPisa5nackD4ZvsM4y1l8OLFuEYN5nMgk025+VKokJmbc7rsqFe F/Zfusmcp+QBehQF3y+lV0zMfEZAVKIj62BnIsl+ayyDZskHVw3yIjtbAit0ZFzp47RpVejt 60SZhApfVLRs8SW6p3GP0Md8uxEnDMWhLBKgupUC7aKJ0=
- Ironport-sdr: 4kLbUBEMymQvmuh5kHi2WnKYKlhl+UQQWhAXtj9X7Ee+InWBQXY9H+aAyl0z3mFhATbyb+UoPE yszODfQhcek7ThwxoftrRE2h076LJmrevhQu4MoSRTFsvJYhGwyI1kQDq8tFmjH72H6gKL77P3 oo9sXDuhTFZoFBGmn616S9MmwmNCnbyyUZiqupbLH4GJI5fUFaZBs8YYdanZel3ze5j7wqu7lu S6KU2ktq92DZASM9+6izs2BAYy3ided616F5x+1VBKX06/DYZTywzKZ8HnT7so+BoWF63CXRVV OBE=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 25/03/2021 16:52, Andrew Cooper wrote:
> From: Jan Beulich <jbeulich@xxxxxxxx>
>
> Commit e1de4c196a2e ("x86/timer: Fix boot on Intel systems using ITSSPRC
> static PIT clock gating") was reported to cause boot failures on certain
> AMD Ryzen systems.
>
> Refine the fix to do nothing in the default case, and only attempt to
> configure legacy replacement mode if IRQ0 is found to not be working.
>
> In addition, introduce a "hpet" command line option so this heuristic
> can be overridden. Since it makes little sense to introduce just
> "hpet=legacy-replacement", also allow for a boolean argument as well as
> "broadcast" to replace the separate "hpetbroadcast" option.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> ---
> CC: Jan Beulich <JBeulich@xxxxxxxx>
> CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> CC: Wei Liu <wl@xxxxxxx>
> CC: Ian Jackson <iwj@xxxxxxxxxxxxxx>
> CC: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
> CC: Frédéric Pierret <frederic.pierret@xxxxxxxxxxxx>
>
> For 4.15: Attempt to unbreak AMD Ryzen 1800X systems.
Sorry - lost a hunk during a rebase (the one to cope with hpet=0). I'll
fold that in and post a v1.1 in due course.
|
