[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH-for-4.15 V2] tools/libs/store: tidy up libxenstore interface


  • To: Juergen Gross <jgross@xxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Wed, 24 Mar 2021 11:42:51 +0000
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JKd9B4wxj3mHQdzJbIbkPAbgWlz5P5GDOl309bUAC5E=; b=SovTRgd1xrU+4yyjPPsSQ6g8rob/3fKl3G/Wailhxt7cZiNy7WnLhH/lWcXUVHBiTks+fxe1i4lrPAwq015bIwCzsbUXWW0GMTu0nAZYOvBFUDKzL8HLUOACR68jISV1anFm+CkvHinLRWCsl8FYYYls4HyXHscno9luUoRfXphHAcZkHoPpHwmU9O80Bhvk/NCspeqbrXTZM6kOZhWl4PZBHxDvJxft8p+rBqGUejgB5giTBurO9Lwwm1inVMvmmMTlZb9qWoCF4GEM+8PdPL/WroQi7YC7XQ+wrOfqCLhzDTggmttBD6sLkCTh4eeRl+BLUUqu2fwXzXis5VtC/w==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XUBSzl8nJ1glbG1xdkEmyJCktEUo979yBQrpaGYCHl1RK8ePhsuZigtTG0KCWp8e9QU7z7b6jgnwfCOBXJCvlq1htubZWdSqLexnpBulcycFoSQQYBSzxhwZYTVMRH+DQxLmsQTM4mfZUdCDkqQ3A9ffOk3mZqaVDtsVM7z/PJl1dhLwDbpulszVlcfc0AMYiNd540kH736k/qp6RCgZcXWKZgQq0NFQrdg4R8rAJ0RpQ7gWFDGeriubzlUWP4C8vFdG3O4Q8kZg7p6C7tmLvvahAjdg39SbK9diXmrwP+r2ZydCgW8G1PaiePUcBUKs4ZYlOsYApBYZ5O7mhHVvlQ==
  • Authentication-results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: Ian Jackson <iwj@xxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Wed, 24 Mar 2021 11:43:13 +0000
  • Ironport-hdrordr: A9a23:FKPoRq012CbDQSChREYnmgqjBTt3eYIsi2QD101hICF9Wvez0+ izgfUW0gL1gj4NWHcm3euNIrWEXGm0z/FIyKErF/OHUBP9sGWlaLtj44zr3iH6F0TFmtJ1/Z xLN5JzANiYNzVHpO7n/Qi1FMshytGb8KauwdzT1WtpUBsCUcBdxi1SYzzrd3Febg9AGJY/Cd 647s1IuzKvdR0sH7uGL1MCWPXOoMCOqYnvZgQICwVixA6Fiz6p77CSKWnl4j41VTRTzbA+tV XUigCR3NTfj9iX6D/5k1XS4ZNfhcf7xrJ4avCkp8AJJlzX+36VTat7XbnqhkFTnMiO7xIQnM DIs1McOa1ImgnsV0WUhTeo5AX6yjYp7BbZuCylqF/uu9bwSj5/K+cpv/MhTjLj50AtvM5x3c twtgrz3fonbmK0oA3H69fFTB1snEavyEBS9dI7tHBDTZAYLIZYsI13xjIkLL47ACn45Io7ed Meav302fA+SyL5U1nkpGV1hPSjUnMvdy32OXQqi4i+1jhbm21B1E0IxMATtWdozuNNd7B0o8 vDKahmj7dIU4s/ar98Hv4IRY+NBnXKWg+kChPfHX3XUIU8f17doZ/+57s4oMmsZZwz1ZM33L DMSklRu2Iec1/nYPf+k6Fjw1ToeiGQTD7twsZR69xSobvnXofmNiWFVRQHj9agi+93OLyaZ9 +DfLZtR9PzJ2rnHohEmyfkXYNJFHUYWMoJ/v4mRlO1pN7RIIGCjJ2bTN/jYJ7WVRo0UGL2BX UOGBLpIt9b00ytUnjkxDfLXXfAfVH+4IJQHKDW8/N78vlOCqR89iwuzXip7MCCLjNP9oYsel FlHb/hmqSn4Um6lFy4qllBC154NAJ48b/gW3RFqUshKEXva4sOvN2ZZCR31HuDLRlvctPOHG dk1hBK0JPyC6bV6TEpCtqhPG7fpWAUvmi2Q5AVnbDGwsv5ZJUiDNIDVLZqHQvGUzx58Dwa5l trWUshfAvyBznugaKqgNg/H+fEbeRxhw+tPIpzsnLQtUKVoOk1XXsFVzuSUcqa6DxeBAZ8tx lUyesykbCAkTGgJS8Um+IjKmBBb2yRHfZ7FgifXZ5VnbrqYQl0am+PiVWh+lYOU1uv039Xqn 3qLCWSd/2OJlZGoHhX3pzn905OenyHc1h9bW17toNBBX3L00wDo9OjV+6W6S+8e1ECyuYSPH X+bTweLhhH6vq32BSW8QzyXkkO99ELBKjwHb4je7bc1jeRM4WOj7gBBOIR1o1iLsrSvugCVv +/dweZICjjMf4g3xWYqx8eSW9JgUhhtcmt/hLr7GK1hiFiRdXTJUlrXLEdLZW36XP+S/OBzZ V+ipYUsIKLQxLMQ+/D7ZuSSThJbi73iyqRacoDrJhPp6I8tLdpBfDgIHP1/UAC+C97Fdv+kU MVfb9y77/AMLJ+ZsB6QVMswnMZ0PC0aHYxugP4AuUCbUggon/SMdSO+afJo9MUczu8jTq1HV mU6CtG+fjZGwOFyL4BEqo1SF4mInQU2TBH/OmYcZfXBxjvX+Zf/ECiOnv4VLNGUqCKFfExqR l9iuv40tO/Rm7d2ArKuyF8Lb8L22G7QdmqCAbJINV2ybWBSB2xq5rvxtWygjfxQSa6bEpdpb QtTz1vUu1zzh84jIM21SCuTLfQuUxNqSoG3Q1a
  • Ironport-sdr: xm8KVo4MB8Sx3+daxYp6XgfvZ+ispejru2YQuMCnk6PvQ++HQsCnkoEJKkeurAKvgUBSgPtL9B 2i9Si85tucmSYaXXksLtYeYluKfYNtl2P9VcXro5phBYAcYgfBj4cnqdCg2wCMxwnwvuEU97Ue JA67Gz3t0oflwD6vismM7G3xG8syXOgRSHdqej8egsr2y+7ZSSYO+csDmSFnAa4UDNyjAfBgCU yoqjR6t+6XZ8hqSXYdqWeK5nOq8SJRnqpuoNGVWabw1n8ZEJRYOPllWNkVLnPZB1+HqRRIgc55 0iQ=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 24/03/2021 11:30, Juergen Gross wrote:
> xenstore_lib.h is in need to be tidied up a little bit:
>
> - the definition of struct xs_tdb_record_hdr shouldn't be here
> - some symbols are not namespaced correctly
>
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> ---
> V2: minimal variant (Ian Jackson)
> ---
>  tools/include/xenstore_lib.h     | 17 ++++-------------
>  tools/libs/store/libxenstore.map |  6 +++---
>  tools/libs/store/xs.c            | 12 ++++++------
>  tools/xenstore/utils.h           | 11 +++++++++++
>  tools/xenstore/xenstore_client.c | 12 ++++++------
>  5 files changed, 30 insertions(+), 28 deletions(-)
>
> diff --git a/tools/include/xenstore_lib.h b/tools/include/xenstore_lib.h
> index 4c9b6d1685..f74ad7024b 100644
> --- a/tools/include/xenstore_lib.h
> +++ b/tools/include/xenstore_lib.h
> @@ -43,15 +43,6 @@ struct xs_permissions
>       enum xs_perm_type perms;

^ This enum is still a ABI problem, as it has implementation defined
size.  The containing struct is used by xs_perm_to_string().

Substituting for int is probably the easiest option, because no amount
of trickery with the enum values themselves can prevent the compiler
deciding to use a long or larger for the object.

~Andrew




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.